FreeCalypso > hg > fc-magnetite

view src/cs/services/tty/tty_env.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/**
 * @file	tty_env.h
 *
 * Declarations of the Riviera Generic Functions 
 *
 * @author	Frederic Turgis (f-turgis@ti.com) & Gerard Cauvy (g-cauvy@ti.com)
 * @version 0.1
 */

/*
 * History:
 *
 * 	Date       	Modification
 *  ------------------------------------
 *  01/27/2003	Create
 *
 * (C) Copyright 2003 by Texas Instruments Incorporated, All Rights Reserved
 */

#ifndef __TTY_ENV_H_
#define __TTY_ENV_H_


#include "rvm/rvm_gen.h"		/* Generic RVM types and functions. */
//#include "rvf/rvf_pool_size.h"	/* Stack & Memory Bank sizes definitions */
#include "tty/tty_pool_size.h"	/* Stack & Memory Bank sizes definitions */


/**
 * @name Mem bank
 *
 * Memory bank size and watermark.
 */
/*@{*/
#define TTY_MB_PRIM_SIZE				TTY_MB1_SIZE
#define TTY_MB_PRIM_WATERMARK			(TTY_MB_PRIM_SIZE - 256)
/*@}*/


/**
 * @name Generic functions
 *
 * Generic functions declarations needed for a type 2 SWE
 * (Group Member SWE).
 */
/*@{*/
T_RVM_RETURN tty_get_info (T_RVM_INFO_SWE  *info_swe);

T_RVM_RETURN tty_set_info ( T_RVF_G_ADDR_ID  addr_id,
							T_RV_RETURN_PATH return_path[],
							T_RVF_MB_ID      bk_id_table[],
							T_RVM_CB_FUNC    call_back_error_ft);

T_RVM_RETURN tty_init (void);

T_RVM_RETURN tty_stop (void);

T_RVM_RETURN tty_kill (void);
/*@}*/

#endif /*__TTY_ENV_H_*/