FreeCalypso > hg > fc-magnetite
view src/cs/services/tty/tty_i.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 945cf7f506b2 |
| children |
line wrap: on
line source
/** * @file tty_i.h * * Internal definitions for TTY. * * @author Frederic Turgis (f-turgis@ti.com) & Gerard Cauvy (g-cauvy@ti.com) * @version 0.1 */ /* * History: * * Date Modification * ------------------------------------ * 01/27/2003 Create * * (C) Copyright 2003 by Texas Instruments Incorporated, All Rights Reserved */ #ifndef __TTY_I_H_ #define __TTY_I_H_ #include "rv/rv_general.h" #include "rvm/rvm_gen.h" #include "rvf/rvf_api.h" #include "rvm/rvm_use_id_list.h" /* TTY entity (Background Task) is HIGHLY linked to the Audio entity. */ #include "audio/audio_api.h" /* Macro definition for sending trace */ #define TTY_SEND_TRACE(text,level) rvf_send_trace(text, sizeof(text)-1, NULL_PARAM, level, TTY_USE_ID ) /* Events Masks for TTY SWE. */ #define TTY_DATA_EVENT_MASK (EVENT_MASK(RVF_APPL_EVT_0)) #define TTY_INIT_EVENT_MASK (EVENT_MASK(RVF_APPL_EVT_1)) #define TTY_EXIT_EVENT_MASK (EVENT_MASK(RVF_APPL_EVT_2)) /* TTY Control Block. */ typedef struct { /** * Return path of the input result (should be the return path to access * to the SWE we are communicating with). */ T_RV_RETURN_PATH return_path; /** Pointer to the error function */ T_RVM_RETURN (*error_ft)(T_RVM_NAME swe_name, T_RVM_RETURN error_cause, T_RVM_ERROR_TYPE error_type, T_RVM_STRING error_msg); /** Mem bank id. */ T_RVF_MB_ID prim_mb_id; /** Address ID of TTY SWE */ T_RVF_G_ADDR_ID addr_id; UINT8 state; } T_TTY_ENV_CTRL_BLK; /* Internal messages definition */ #define TTY_START_REQ (0x00F0 | AUDIO_EVENT_INTERN | AUDIO_EVENTS_MASK) typedef struct { T_RV_HDR os_hdr; T_RV_RETURN return_path; } T_TTY_START; #define TTY_STOP_REQ (0x00F1 | AUDIO_EVENT_INTERN | AUDIO_EVENTS_MASK) typedef struct { T_RV_HDR os_hdr; T_RV_RETURN return_path; } T_TTY_STOP; /* Define all the state of the TTY State Machine */ #define TTY_IDLE (1) #define TTY_WAIT_START_CON (2) #define TTY_WAIT_STOP_COMMAND (3) #define TTY_WAIT_START_CON_TO_STOP (4) #define TTY_WAIT_STOP_CON (5) #endif /* __TTY_I_H_ */