FreeCalypso > hg > fc-magnetite

view src/cs/services/tty/tty_task.c @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/**
 * @file   tty_task.c
 *
 * Coding of the main TTY function : tty_core
 * This function loop in the process message function for waiting messages.
 *
 * @author	Frederic Turgis (f-turgis@ti.com) & Gerard Cauvy (g-cauvy@ti.com)
 * @version 0.1
 */

/*
 * History:
 *
 * 	Date       	Modification
 *  ------------------------------------
 *  01/27/2003	Create
 *
 * (C) Copyright 2003 by Texas Instruments Incorporated, All Rights Reserved
 */

#ifndef _WINDOWS
  #include "config/l1sw.cfg"
#endif

#include "tty/tty_env.h"
#include "tty/tty_i.h"

#include "rv/rv_general.h"
#include "rvf/rvf_api.h"
#include "rvm/rvm_use_id_list.h"

#if (TRACE_TYPE == 1) || (TRACE_TYPE == 4)
  #ifndef _WINDOWS
    #include "config/sys.cfg"
    #include "config/chipset.cfg"
  #endif
  #include "l1_types.h"
  #include "l1_confg.h"
  #include "l1_trace.h"
#endif

#if (L1_GTT == 1)
  /* External prototype. */
  extern void l1gtt_initialize(void);
  extern void l1gtt_exit(void);
  extern void l1gtt_main_processing(void);
  extern void l1gtt_init_trace(void);
#else
  /* Dummy functions */
  void l1gtt_initialize(void) {}
  void l1gtt_exit(void) {}
  void l1gtt_main_processing(void) {}
  void l1gtt_init_trace(void) {}
#endif


/**
 * @name Functions implementation
 *
 */
/*@{*/

/**
 * function: tty_core
 */
T_RV_RET tty_core(void)
{
  BOOLEAN error_occured = FALSE;
  T_RV_HDR* msg_p;
  UINT16 received_event;

  TTY_SEND_TRACE("TTY TASK Started", RV_TRACE_LEVEL_DEBUG_HIGH );

  l1gtt_init_trace();

  /* loop to process messages */
  while (error_occured == FALSE)
  {
    /* Wait for the necessary events. */
    received_event = rvf_wait ( 0xffff,0);

    if (received_event & TTY_INIT_EVENT_MASK)
    {
      l1gtt_initialize();
    }
    else if (received_event & TTY_EXIT_EVENT_MASK)
    {
      l1gtt_exit();
    }
    else if (received_event & TTY_DATA_EVENT_MASK)
    {
      l1gtt_main_processing();
    }
  }

  return RV_OK;
}