FreeCalypso > hg > fc-magnetite

view src/g23m-aci/aci/aci_lst.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 53929b40109c
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GSM-PS (6147)
|  Modul   :  aci_lst
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Process lists in ACI
+----------------------------------------------------------------------------- 
*/ 

#ifndef ACI_LST_H
#define ACI_LST_H


/*==== TYPES ======================================================*/

typedef struct ACI_LIST_S
{
  void               *msg;
  struct ACI_LIST_S  *next;
} T_ACI_LIST;

typedef BOOL  T_LIST_FIND_FCT (UBYTE criterium, void *elem);
typedef BOOL  T_LIST_FIND_FCT_PSI (U32 criterium, void *elem);

/*==== PROTOTYPES =================================================*/

/*==== EXPORT =====================================================*/

EXTERN USHORT get_list_count      (T_ACI_LIST *list);
EXTERN T_ACI_LIST *new_list       (void);
EXTERN BOOL insert_list           (T_ACI_LIST       *list, 
                                   void             *buffer);
EXTERN BOOL insert_shift_list (T_ACI_LIST *list, void *buffer);

EXTERN void *get_next_element     (T_ACI_LIST       *search_list, 
                                   void             *prev_elem);

EXTERN void *find_next_element    (T_ACI_LIST       *search_list, 
                                   void             *prev_elem,
                                   UBYTE            criterium, 
                                   T_LIST_FIND_FCT  test_criterium);

EXTERN void *find_element         (T_ACI_LIST       *search_list, 
                                   UBYTE            criterium, 
                                   T_LIST_FIND_FCT  test_criterium);


EXTERN void *remove_first_element (T_ACI_LIST       *search_list);
EXTERN void *remove_element       (T_ACI_LIST       *search_list, 
                                   UBYTE            criterium, 
                                   T_LIST_FIND_FCT  test_criterium);
#ifdef FF_PSI
EXTERN void *psi_find_next_element    (T_ACI_LIST       *search_list, 
                                   void             *prev_elem,
                                   U32           criterium, 
                                   T_LIST_FIND_FCT_PSI  test_criterium);
EXTERN void *psi_find_element (T_ACI_LIST *search_list,
                           U32 criterium,
                           T_LIST_FIND_FCT_PSI test_criterium);
EXTERN void *psi_remove_element       (T_ACI_LIST       *search_list, 
                                   U32            criterium, 
                                   T_LIST_FIND_FCT_PSI test_criterium);
#endif /*FF_PSI*/

#endif