FreeCalypso > hg > fc-magnetite
view src/g23m-aci/aci/ati_io.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 53929b40109c |
| children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : GSM-F&D (8411) | Modul : ATI +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : +----------------------------------------------------------------------------- */ #ifndef ATI_IO_H #define ATI_IO_H EXTERN void io_sendChar ( CHAR a, UBYTE srcId ); EXTERN UBYTE uart_new_source( UBYTE device, UBYTE dlci ); #ifdef UART EXTERN void uart_InitCmdStruct( T_ACI_DTI_PRC *cmd_struct ); #endif #define IS_END_CRLF_OUTPUT(x) (x & ATI_END_CRLF_OUTPUT) #define IS_BEGIN_CRLF_OUTPUT(x) (x & ATI_BEGIN_CRLF_OUTPUT) #define IS_ECHO_OUTPUT(x) (x & ATI_ECHO_OUTPUT) #define IS_NORMAL_OUTPUT(x) (x & ATI_NORMAL_OUTPUT) #define IS_CONFIRM_OUTPUT(x) (x & ATI_CONFIRM_OUTPUT) #define IS_INDICATION_OUTPUT(x) (x & ATI_INDICATION_OUTPUT) #define IS_FORCED_OUTPUT(x) (x & ATI_FORCED_OUTPUT) #define IS_ERROR_OUTPUT(x) (x & ATI_ERROR_OUTPUT) #define IS_INFORMATION_TEXT_OUTPUT(x) (x & ATI_INFORMATION_TEXT_OUTPUT) #define IS_RESULT_CODE_OUTPUT(x) (x & ATI_RESULT_CODE_OUTPUT) #endif