FreeCalypso > hg > fc-magnetite

view src/g23m-aci/aci/db_int.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 53929b40109c
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  PHB
|  Modul   :  DBM
+----------------------------------------------------------------------------- 
|  Copyright 2005 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Internal declarations for DBM module
+----------------------------------------------------------------------------- 
*/ 
#ifndef DB_INT_H
#define DB_INT_H

#include "db.h"

/* This macro allows us to close the file before
   returning from function */
#define FFS_OPEN_PROBLEM_PATCH

/* If this macro is activated, we close earlier activated file
   before opening next file */
#define FFS_CLOSE_BEFORE_OPEN

/* Mutually exclusive macros */
#ifdef FFS_CLOSE_BEFORE_OPEN
#undef FFS_OPEN_PROBLEM_PATCH
#endif

#ifdef FFS_CLOSE_BEFORE_OPEN

  #define MAX_OPEN_READ_PER_DB 2
  #define MAX_OPEN_WRITE_PER_DB 1

#endif

#ifdef _SIMULATION_
  #include "ffs_pc_api.h"
#else
  #include "ffs/ffs.h"
#endif

#include "vsi.h"
#include "aci_mem.h"

#define RECORD_BITMAP_SIZE      32  /* Based on MAX_NUM_RECORDS 
                                        RECORD_BITMAP_SIZE = MAX_NUM_RECORDS/8*/
#define MAX_LEN_DIRECTORY       16  /* Assumed to be max 16 characters        */


/* 
    DBM state 
 */
typedef enum
{
  
  DBM_NOT_INITIALISED = 0, 
  DBM_INITIALISED 

} T_DBM_STATE;

/* 
    Database state 
*/
typedef enum
{ 

  CLOSED = 0, 
  OPEN,
  IN_USE,
  UNUSED_ENTRY = 0xFF

} T_DB_STATE;

#ifdef FFS_CLOSE_BEFORE_OPEN

typedef struct
{

  UBYTE    fld_ctr;
  T_FFS_FD filehandle;

} FileHandleRecord;

#endif

/* 
    Field record
 */
typedef struct
{

  USHORT    FieldID;                                /* Elementary file identifier                           */
  T_DB_TYPE DBType;                                 /* database type (UNMANAGED, FREELIST)                  */
  USHORT    RecordSize;                             /* Size of data in data base record                     */
  UBYTE     NumOfRecords;                           /* Number of records                                    */
  UBYTE     UsedRecords;                            /* Number of used records                               */
  UBYTE     RecordBitMap [RECORD_BITMAP_SIZE];      /* Bitmap representing whether record is present or not */
  BOOL      Clean;                                  /* File consistency                                     */
  UBYTE     SortIndexList [MAX_NUM_OF_SORT_INDEXS]; /* Number of associated index files                     */
  UBYTE*    SortedLists [MAX_NUM_OF_SORT_INDEXS];   /* Sorted lists                                         */

#ifndef FFS_CLOSE_BEFORE_OPEN
  T_FFS_FD  FFSFileHandle;                          /* FFS File Handle for User file                        */
#endif

  UBYTE     NextRecordNum;                          /* To take care of non-seqential write                  */

} T_DBM_FIELDRECORD;


typedef struct 
{

  UBYTE               DBDirectory[MAX_LEN_DIRECTORY]; /* Directory path                                       */
  UBYTE               NumOfFiles;                     /* Maximum files in that database                       */
  UBYTE               UsedFiles;                      /* Number of used files                                 */
  BOOL                Clean;                          /* Clean: Database is consistent                        */
  BOOL                Tracked;                        /* Tracked: History log to be maintained                */
  T_DB_STATE          DBState;                        /* Database state                                       */

  T_FFS_FD            FFSFileHandle;                  /* FFS File Handle for DD_<db_handle>                   */

#ifdef FFS_CLOSE_BEFORE_OPEN
  FileHandleRecord READ_OPEN_FIELDS [MAX_OPEN_READ_PER_DB];   /* fields opened for read only                  */
  FileHandleRecord WRITE_OPEN_FIELDS [MAX_OPEN_WRITE_PER_DB]; /* fields opened for read/write both            */
  UBYTE  old_read;                                            /* remeber oldest open                          */
  UBYTE  old_write;                                           /* remeber oldest read                          */
#endif

  T_DBM_FIELDRECORD*  ptrFieldRecord;                 /* pointer to fields                                    */

} T_DBM_MASTERRECORD;

#endif