FreeCalypso > hg > fc-magnetite

view src/g23m-aci/aci/gaci_cmd.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 53929b40109c
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  
|  Modul   :  
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  GPRS Command handler interface definitions.
+----------------------------------------------------------------------------- 
*/ 

/* needs: aci_cmd.h */

#ifndef GACI_CMD_H
#define GACI_CMD_H

/* sub structure concerning AT+CGREG and
AT%CGREG command in ATI */

typedef struct
{
  T_ATI_REG_MOD_LAC_CID mod_lac_cid;
  T_CGREG_STAT          last_presented_state;
} T_ATI_CGREG;

typedef struct
{
  T_ATI_REG_MOD_LAC_CID mod_lac_cid;
  T_P_CGREG_STAT        last_presented_state;
} T_ATI_P_CGREG;

typedef struct
{
  T_ATI_CGREG    plus_cgreg;
  T_ATI_P_CGREG  percent_cgreg;

} T_ATI_GPRS_USER_OUTPUT_CFG;


EXTERN void gaci_ati_cmd_init_each_source( UBYTE srcId );


#ifdef ACI_CMD_C
/* next variable is aimed at containing the user defined configuration
for the output format through AT interpreter for GPRS */
GLOBAL T_ATI_GPRS_USER_OUTPUT_CFG ati_gprs_user_output_cfg[CMD_SRC_MAX];

#else /* ACI_CMD_C */

EXTERN T_ATI_GPRS_USER_OUTPUT_CFG ati_gprs_user_output_cfg[CMD_SRC_MAX];
#endif /* ACI_CMD_C */


#endif /* GACI_CMD_H */
/*==== EOF ========================================================*/