FreeCalypso > hg > fc-magnetite
view src/g23m-aci/aci/l4_tim.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 53929b40109c |
| children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : GSM-PS (6147) | Modul : L4_TIM +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : Definitions of timer indices +----------------------------------------------------------------------------- */ /* * Timer Indices */ #define SMI_TBACKLIGHT 0 #define SMI_TSLIDER 1 #define SMI_TSHIFTKEY 2 #define SMI_TUNIVERSAL 3 #define ACI_TRING 4 #define ACI_TMPTY 5 #define ACI_TFIT 6 #define ACI_TDTMF 7 #if defined (FAX_AND_DATA) #define FIT_RUN 8 #endif #define AOC_CALLTIMER 9 #define AOC_AOCTIMER 10 #define MAX_AOC_TIMER 7 /* should be changed to MAX_CALL_NR */ /* timers in between are reserved for AOC */ #define MFW_TIMER (AOC_AOCTIMER+MAX_AOC_TIMER) #define ACI_IPR (MFW_TIMER + 1) #define ACI_TECT (ACI_IPR + 1) #define ACI_TDELAY (ACI_TECT + 1) #if defined FF_EOTD /*&& defined _SIMULATION_*/ #define ACI_LC_1 (ACI_TDELAY+1) #define ACI_LC_2 (ACI_LC_1+1) #define ACI_LC_3 (ACI_LC_1+2) #define ACI_LC_4 (ACI_LC_1+3) #define ACI_LC_5 (ACI_LC_1+4) #endif #ifndef FF_EOTD #define ACI_REPEAT_HND (ACI_TDELAY +1) #else #define ACI_REPEAT_HND (ACI_LC_1+5) #endif /* FF_EOTD */ #ifdef SIM_TOOLKIT #define ACI_SAT_MAX_DUR_HND (ACI_REPEAT_HND +1) #define ACI_CNMA_TIMER_HANDLE (ACI_SAT_MAX_DUR_HND+1) #else #define ACI_CNMA_TIMER_HANDLE (ACI_REPEAT_HND+1) #endif /* SIM_TOOLKIT */ #ifdef VOCODER_FUNC_INTERFACE #define ACI_VOCODER (ACI_CNMA_TIMER_HANDLE+1) #endif #ifdef SIM_PERS #ifdef VOCODER_FUNC_INTERFACE #define ACI_UNLOCK_TIMER_HANDLE (ACI_VOCODER+1) #else #define ACI_UNLOCK_TIMER_HANDLE (ACI_CNMA_TIMER_HANDLE+1) #endif #endif #define ACI_REPEAT_1 5000 /* 5 sec for waiting for 1th redialling */ #define ACI_REPEAT_2_4 60000 /* 1 min for waiting for 2th to 4th redialling */ #define ACI_CNMA_TIMER_VALUE 15000 /* 15 sec. for waiting for the +CNMA */ #define ACI_DELAY_TIMER 5000 /* 5 sec delay for various REDIAL attempts */ #ifdef SIM_PERS #define ACI_UNLOCK_TIMER 10000 /* 2 sec delay for various wrong unlock/unblock attempts */ #endif