view src/g23m-aci/aci/psa_raf.c @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 53929b40109c
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GSM-PS (6147)
|  Modul   :  PSA_RAF
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  This module defines the functions for the protocol
|             stack adapter for Rate Adaptation.
+----------------------------------------------------------------------------- 
*/ 

#ifndef PSA_RAF_C
#define PSA_RAF_C
#endif

#include "aci_all.h"

#undef TRACING

/*==== INCLUDES ===================================================*/
#include "aci_cmh.h"
#include "ati_cmd.h"
#include "aci_cmd.h"

#ifdef FAX_AND_DATA
  #include "aci_fd.h"
#endif

#include "aci.h"
#include "psa.h"
#include "aci_io.h"
#include "psa_ra.h"
#include "cmh.h"
#include "cmh_ra.h"
#include "psa_util.h"

/*==== CONSTANTS ==================================================*/
#define ITM_WDT         (14)    /* item width in chars */
#define HDR_WDT         (10)    /* header width in chars */

/*==== TYPES ======================================================*/


/*==== EXPORT =====================================================*/

/*==== VARIABLES ==================================================*/

/*==== FUNCTIONS ==================================================*/

/*
+-------------------------------------------------------------------+
| PROJECT : GSM-PS (6147)         MODULE  : PSA_RA                  |
|                                 ROUTINE : psaRA_Init              |
+-------------------------------------------------------------------+

  PURPOSE : initialize the protocol stack adapter for RA.

*/

GLOBAL void psaRA_Init ( void )
{
  extern void dll_init(void);

  memset (&raShrdPrm, 0, sizeof (T_RA_SHRD_PRM));

  dll_init ();
}

/*
+-------------------------------------------------------------------+
| PROJECT : GSM-PS (6147)         MODULE  : PSA_RAF                 |
|                                 ROUTINE : psaRA_shrPrmDump        |
+-------------------------------------------------------------------+

  PURPOSE : this function dumps the shared parameter to the debug
            output.
*/

#ifdef TRACING
GLOBAL void psaRA_shrPrmDump ( void )
{
  char  lnBuf[80];              /* holds buffer for output line */ 
  SHORT chrNr;                  /* holds number of processed chars */
  SHORT itmIdx;

  /* --- mode --------------------------------------------------*/
  chrNr  = sprintf( lnBuf, "%*.*s", HDR_WDT, HDR_WDT, "     model" );
  for( itmIdx = 0; (itmIdx<2); itmIdx++ )
  {
    chrNr += sprintf( lnBuf+chrNr, "%*d", ITM_WDT, 
                      raShrdPrm.set_prm[itmIdx].model );
  }
  TRACE_EVENT( lnBuf );

  /* --- transmission rate -------------------------------------*/
  chrNr  = sprintf( lnBuf, "%*.*s", HDR_WDT, HDR_WDT, "trans rate" );
  for( itmIdx = 0; (itmIdx<2); itmIdx++ )
  {
    chrNr += sprintf( lnBuf+chrNr, "%*d", ITM_WDT, 
                      raShrdPrm.set_prm[itmIdx].tra_rate );
  }
  TRACE_EVENT( lnBuf );

  /* --- user rate ---------------------------------------------*/
  chrNr  = sprintf( lnBuf, "%*.*s", HDR_WDT, HDR_WDT, " user rate" );
  for( itmIdx = 0; (itmIdx<2); itmIdx++ )
  {
    chrNr += sprintf( lnBuf+chrNr, "%*d", ITM_WDT, 
                      raShrdPrm.set_prm[itmIdx].user_rate );
  }
  TRACE_EVENT( lnBuf );

  /* --- no. data bits -----------------------------------------*/
  chrNr  = sprintf( lnBuf, "%*.*s", HDR_WDT, HDR_WDT, " data bits" );
  for( itmIdx = 0; (itmIdx<2); itmIdx++ )
  {
    chrNr += sprintf( lnBuf+chrNr, "%*d", ITM_WDT, 
                      raShrdPrm.set_prm[itmIdx].ndb );
  }
  TRACE_EVENT( lnBuf );

  /* --- no. stop bits -----------------------------------------*/
  chrNr  = sprintf( lnBuf, "%*.*s", HDR_WDT, HDR_WDT, " stop bits" );
  for( itmIdx = 0; (itmIdx<2); itmIdx++ )
  {
    chrNr += sprintf( lnBuf+chrNr, "%*d", ITM_WDT, 
                      raShrdPrm.set_prm[itmIdx].nsb );
  }
  TRACE_EVENT( lnBuf );

  /* --- owner -------------------------------------------------*/
  chrNr  = sprintf( lnBuf, "%*.*s", HDR_WDT, HDR_WDT, "     owner" );

  chrNr += sprintf( lnBuf+chrNr, "%*d", ITM_WDT, raShrdPrm.owner );
  TRACE_EVENT( lnBuf );

  /* --- call id -----------------------------------------------*/
  chrNr  = sprintf( lnBuf, "%*.*s", HDR_WDT, HDR_WDT, "   call id" );

  chrNr += sprintf( lnBuf+chrNr, "%*d", ITM_WDT, raShrdPrm.cId );
  TRACE_EVENT( lnBuf );
}
#endif  /* of #ifdef TRACING */

/*==== EOF ========================================================*/