FreeCalypso > hg > fc-magnetite

view src/g23m-aci/aci/psa_sm.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 53929b40109c
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  
|  Modul   :  
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions for the protocol stack adapter 
|             GPRS session management ( SM ).
+----------------------------------------------------------------------------- 
*/ 

#ifdef GPRS

#ifndef PSA_SM_H
#define PSA_SM_H



/*==== CONSTANTS ==================================================*/

/*==== TYPES ======================================================*/
typedef struct SMSetParm
{
  T_SMREG_PDP_ACTIVATE_REQ *pact;    /* primitive parameter */
  T_SMREG_PDP_ACTIVATE_REQ act;     /* primitive parameter */
} T_SM_SET_PRM;

typedef struct SMShrdParm
{
  /* state parameter */
  UBYTE             direc;          /* parameter for primitive SMREG_PDP_ACTIVATE_REQ */

  /* set parameter */
  UBYTE             owner;          /* identifies the used set */
  T_SM_SET_PRM setPrm[OWN_SRC_MAX];     /* possible sets */

  /* answer parameter */
  T_SMREG_PDP_ACTIVATE_CNF *pdp_cnf;       /* primitive parameter                  */
  T_SMREG_PDP_ACTIVATE_REJ *pdp_rej;       /* primitive parameter                  */
  T_SMREG_PDP_ACTIVATE_IND  act_ind;       /* primitive parameter                  */
  T_CAUSE_ps_cause         mod_rej_cause; /* smreg_pdp_modify_rej cause parameter */
  USHORT                    nsapi_set;     /* 1 - 15 N-SAPI - ...                  */
  T_PS_ctrl_qos             ctrl_mod_qos;  /*                                      */
  T_PS_qos                  mod_qos;       /* QOS - modify indication              */
} T_SM_SHRD_PRM;

/*==== PROTOTYPES =================================================*/

void  psaSM_Init            ( void );

#ifdef DTI
EXTERN void psaSM_smreg_configure_req(U8 rat, U8 cn_release);
EXTERN void psaSM_PDP_Deactivate        ( USHORT nsapi_set, 
                                          UBYTE  smreg_local );
EXTERN void psaSM_smreg_pdp_activate_req( U8  cid,                                          
                                          U8  hcomp,
                                          U8  dcomp);
#ifdef REL99
EXTERN void psaSM_smreg_pdp_activate_sec_req( U8  cid );
#endif /* REL99 */

EXTERN void psaSM_PDP_Modify( void );
EXTERN void psaSM_PDP_No_activate ( UBYTE smreg_ti, USHORT smreg_cause );
#endif /*DTI*/
EXTERN void psaSM_ActivateReq ( SHORT cid,
                                UBYTE hcomp,
                                ULONG dti_linkid, 
                                ULONG dti_neighbor, 
                                UBYTE dti_direction );

/*==== EXPORT =====================================================*/

#ifdef PSA_SMF_C

GLOBAL T_SM_SHRD_PRM smShrdPrm;

#else

EXTERN T_SM_SHRD_PRM smShrdPrm;

#endif /* PSA_SMF_C */

#endif /* PSA_SM_H */

#endif  /* GPRS */
/*==== EOF =======================================================*/