view src/g23m-aci/aci/psa_t30.h @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 53929b40109c
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GSM-PS (6147)
|  Modul   :  PSA_T30
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions for the protocol stack adapter T30
+----------------------------------------------------------------------------- 
*/ 

#ifndef PSA_T30_H
#define PSA_T30_H

#ifdef FF_FAX

#define REPORT_MAX    128
#define MSG_SIZE_BITS 2880

/*==== CONSTANTS ==================================================*/

typedef enum
{
  NO_VLD_FS = 0,                  /* not a valid fax status */
  FS_IDL,                         /* fax idle */
  FS_SND_DOC,                     /* sending fax document */
  FS_RCV_DOC,                     /* receiving fax document */
  FS_DOC_TRF                      /* fax document transfered */
} T_T30_FXST;

/*==== TYPES ======================================================*/

typedef struct
{
  UBYTE        dir;
  USHORT       l_buf;
  UBYTE        buf[REPORT_MAX];
} T_Report;

typedef struct T30ShrdParm
{
  SHORT         cId;              /* related call id */
  UBYTE         faxStat;          /* status of fax */
  USHORT        trans_rate;       /* t30_activate_req, t30_modify_req */
  UBYTE         half_rate;        /* t30_activate_req, t30_modify_req */
  UBYTE         threshold;        /* t30_activate_req */
  UBYTE         bitord;           /* t30_activate_req */
  USHORT        frames_per_prim;  /* t30_activate_req */
  USHORT        tbs;              /* t30_activate_cnf */
  USHORT        rbs;              /* t30_activate_cnf */
  T_hdlc_info   hdlc_rcv;         /* t30_cap_ind, t30_cap_req */
  T_hdlc_info   hdlc_snd;         /* t30_cap_ind, t30_cap_req */
  UBYTE         sgn_rcv;          /* t30_sgn_ind */
  UBYTE         sgn_snd;          /* t30_sgn_req */
  UBYTE         cmpl;             /* t30_cmpl_ind */
  UBYTE         hdlc_report;      /* t30_config_req */
  U16           test_mode;        /* t30_config_req */
  USHORT        err_cause;        /* t30_error_ind */
  USHORT        eol;              /* t30_info_ind */
  T_Report      report;           /* t30_report_ind */
  UBYTE         bcs_phase;        /* ks */
  UBYTE         msg_phase;
  BOOL          T30_is_activated;
} T_T30_SHRD_PRM;

typedef struct T30TstPrmRef
{
  const char * key;               /* keyword string */
  UBYTE  id;                      /* corresponding id */
} T30_TSTPRM_REF;

/*==== PROTOTYPES =================================================*/

EXTERN SHORT psaT30_Ppm          (void);

#ifdef DTI
EXTERN void psaT30_Dti_Req    (T_DTI_CONN_LINK_ID link_id, UBYTE dti_conn);
#endif /* DTI */

#ifdef FF_FAX
EXTERN void  psaT30_Init         (void);
#endif

EXTERN SHORT psaT30_Ppm       (void);
EXTERN void  psaT30_Modify       (void);
EXTERN void  psaT30_Disconnect   (void);
EXTERN void  psaT30_Config       (void);
EXTERN void  psaT30_Capabilities (void);
EXTERN void  psaT30_Activate     (void);
EXTERN void  psaT30_Deactivate   (void);

#ifdef TRACING
EXTERN void psaT30_shrPrmDump ( void );
#endif

/*==== EXPORT =====================================================*/

#ifdef PSA_T30F_C

GLOBAL T_T30_SHRD_PRM t30ShrdPrm;

#else

EXTERN T_T30_SHRD_PRM t30ShrdPrm;

#endif /* PSA_T30F_C */

#endif /* FF_FAX */

#endif /* PSA_T30_H */

/*==== EOF =======================================================*/