FreeCalypso > hg > fc-magnetite
view src/g23m-aci/gdd_dio/gdd_dio_queue.c @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | 53929b40109c |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | File : gdd_dio_queue.c +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : Implements the queue functions for the DIO buffer FIFO +----------------------------------------------------------------------------- */ #define ENTITY_GDD_DIO /*==== INCLUDES =============================================================*/ #include "typedefs.h" /* to get Condat data types */ #include "vsi.h" /* to get a lot of macros */ #include <string.h> /* for memset */ #include "gdd_dio_queue.h" /*==== CONST ================================================================*/ /*==== LOCAL VARS ===========================================================*/ /*==== PRIVATE FUNCTIONS ====================================================*/ /*==== PUBLIC FUNCTIONS =====================================================*/ GLOBAL void gdd_dio_queue_clear(T_GDD_BUF_QUEUE *queue) { queue->next_in = 0; queue->next_out = 0; memset(queue->elems, 0, sizeof(T_dio_buffer *) * GDD_MAX_DIO_BUF); } BOOL gdd_dio_queue_is_empty(const T_GDD_BUF_QUEUE *queue) { return (queue->next_in == queue->next_out) && (0 == queue->elems[queue->next_out]); } GLOBAL BOOL gdd_dio_queue_is_full(const T_GDD_BUF_QUEUE *queue) { return (queue->next_in == queue->next_out) && !(0 == queue->elems[queue->next_out]); } GLOBAL BOOL gdd_dio_dequeue(T_GDD_BUF_QUEUE *queue, T_dio_buffer **elem) { if(gdd_dio_queue_is_empty(queue)) { return FALSE; } else { (*elem) = queue->elems[queue->next_out]; queue->elems[queue->next_out] = 0; ++(queue->next_out); if(queue->next_out EQ GDD_MAX_DIO_BUF) queue->next_out = 0; return TRUE; } } GLOBAL BOOL gdd_dio_queue_peek_next_for_dequeue (const T_GDD_BUF_QUEUE *queue, /*out*/T_dio_buffer **elem) { if(gdd_dio_queue_is_empty(queue)) { return FALSE; } else { (*elem) = queue->elems[queue->next_out]; return TRUE; } } GLOBAL BOOL gdd_dio_enqueue(T_dio_buffer *elem, T_GDD_BUF_QUEUE *queue, /*out*/U16 *pos) { if(gdd_dio_queue_is_full(queue)) { return FALSE; } else { queue->elems[queue->next_in] = elem; (*pos) = queue->next_in; ++(queue->next_in); if(queue->next_in EQ GDD_MAX_DIO_BUF) queue->next_in = 0; return TRUE; } } GLOBAL void gdd_dio_queue_peek(const T_GDD_BUF_QUEUE *queue, U16 pos, /*out*/T_dio_buffer **elem) { (*elem) = queue->elems[pos]; }