FreeCalypso > hg > fc-magnetite

view src/g23m-aci/uart/uart_dtxs.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 53929b40109c
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  
|  Modul   :  
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions for uart_dtxs.c 
+----------------------------------------------------------------------------- 
*/ 

#ifndef UART_DTXS_H
#define UART_DTXS_H


EXTERN void sig_ker_dtx_ready_mode_req (UBYTE dlc_instance);

EXTERN void sig_ker_dtx_dead_mode_req (void);

EXTERN void sig_ker_dtx_line_states_req(UBYTE st_flow,
                                        UBYTE st_line_sa,
                                        UBYTE st_line_sb,
                                        UBYTE st_break_len);

EXTERN void sig_rx_dtx_receiving_ind (void);

EXTERN void sig_rx_dtx_data_received_ind (T_desc2* received_data, 
                                          USHORT  write_pos);

EXTERN void sig_ker_dtx_set_dti_peer_req (USHORT tui_peer, 
                                          T_HANDLE peer_handle, 
                                          UBYTE c_id);

#ifdef DTILIB
EXTERN void sig_ker_dtx_set_dtilib_peer_req (void);
#ifdef DTI2
EXTERN void sig_ker_dtx_disconnected_mode_req(void);
EXTERN void sig_ker_dtx_detect_escape_req (UBYTE detect_escape); 
#endif /* DTI2 */
#endif

EXTERN void sig_ker_dtx_timeout_tesd_req (void);


#endif /* !UART_DTXS_H */