FreeCalypso > hg > fc-magnetite

view src/g23m-aci/uart/uart_kers.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 53929b40109c
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  
|  Modul   :  
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions for uart_kers.c 
+----------------------------------------------------------------------------- 
*/ 

#ifndef UART_KERS_H
#define UART_KERS_H

EXTERN void sig_drx_ker_line_states_ind(UBYTE  dlc_instance,
                                        UBYTE  st_flow,
                                        UBYTE  st_line_sa,
                                        UBYTE  st_line_sb,
                                        USHORT st_break_len);

EXTERN void sig_dtx_ker_enable_ind(UBYTE dlc_instance);

EXTERN void sig_dtx_ker_disable_ind(UBYTE dlc_instance);

EXTERN void sig_dtx_ker_escape_detected_ind(U8 dlc_instance);

EXTERN void sig_any_ker_flushed_ind(UBYTE dlc_instance);

EXTERN void sig_tx_ker_flushed_ind(void);

EXTERN void sig_tx_ker_sending_ind (void);

EXTERN void sig_tx_ker_data_sent_ind (T_desc2* rest_data, USHORT write_pos);

EXTERN void sig_rx_ker_receiving_ind (void);

EXTERN void sig_rx_ker_data_received_ind (T_desc2* received_data, 
                                          USHORT write_pos);

EXTERN void sig_rx_ker_line_states_ind (ULONG line_states);

EXTERN void sig_rt_ker_timeout_t1_ind (void);

EXTERN void sig_rt_ker_timeout_t2_ind (void);

EXTERN void sig_rt_ker_timeout_t3_ind (void);

EXTERN void sig_rt_ker_timeout_tesd_ind (void);

EXTERN void sig_dti_ker_connection_closed_ind (U8 dlc_instance);

#endif /* !UART_KERS_H */