view src/g23m-fad/ip/ip_tim.c @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 90eb61ecd093
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GSM-FaD (8411)
|  Modul   :  IP_TIM
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  This Modul defines the timer handling functions
|             for the component
|             Radio Link Protocol of the mobile station
+----------------------------------------------------------------------------- 
*/ 

#define ENTITY_IP

/*==== INCLUDES ===================================================*/

#include <string.h>
#include "typedefs.h"
#include "pconst.cdg"
#include "vsi.h"
#include "macdef.h"
#include "pconst.cdg"
#include "custom.h"
#include "gsm.h"
#include "cnf_ip.h"
#include "mon_ip.h"
#include "prim.h"
#include "pei.h"
#include "tok.h"
#include "ccdapi.h"

#include "dti.h"
#include "ip.h"
#include "ip_udp.h"

/*==== EXPORT =====================================================*/

/*==== PRIVAT =====================================================*/

/*==== VARIABLES ==================================================*/

/*==== FUNCTIONS ==================================================*/

/*
+--------------------------------------------------------------------+
| PROJECT : GSM-FaD (8411)        MODULE  : IP_TIM                   |
| STATE   : code                  ROUTINE : tim_reassembly           |
+--------------------------------------------------------------------+

  PURPOSE : Timeout of timer T_REASSEMBLY

*/

GLOBAL void tim_reassembly (/* USHORT layer, USHORT segm_server*/)
{
  /*
   * shall be replaced for multiple instances by
   * 
   * UBYTE sel_dl_layer = layer;
   * p_dl->pos_server = segm_server;
   */
  /* T_HILA *p_ul = &(ip_data->hila); */
  T_LOLA *p_dl = &(ip_data->lola);
  T_KER *p_ker = &(ip_data->ker);

  
  TRACE_FUNCTION ("tim_reassembly()");
  

  
  switch (GET_STATE (KER))
  {
    
  case CONNECTED:
    {          

      build_ip_packet(FALSE, B_ICMP_REASSEMBLE_TIMEOUT);
    
      p_dl->state_reassembly[p_dl->pos_server] = NO_SEGMENTS;  
      
      /* 
       *  If ready indication is received - send data_req at once
       */
      
      if(GET_STATE(HILA) EQ WAIT)
      {
        T_DTI2_DATA_REQ  *dti_data_req;
    
        p_ker->send_icmp = FALSE;
          
        dti_data_req        = p_ker->icmp_dti_data_req;
              
        dti_data_req          = p_ker->icmp_dti_data_req;
        dti_data_req->parameters.p_id                  = DTI_PID_IP;
        dti_data_req->parameters.st_lines.st_flow      = DTI_FLOW_ON;
        dti_data_req->parameters.st_lines.st_line_sa   = DTI_SA_ON;
        dti_data_req->parameters.st_lines.st_line_sb   = DTI_SB_ON;
        dti_data_req->parameters.st_lines.st_break_len = DTI_BREAK_OFF;
          
        PACCESS (dti_data_req); 
        {
          PPASS(dti_data_req, dti_data_ind, DTI2_DATA_IND);
          dti_send_data(ip_hDTI, IP_DTI_DEF_INSTANCE, IP_DTI_LL_INTERFACE,
          IP_DTI_DEF_CHANNEL, dti_data_ind);
        }
        dti_start(ip_hDTI, IP_DTI_DEF_INSTANCE, IP_DTI_LL_INTERFACE,
        IP_DTI_DEF_CHANNEL); 
        SET_STATE(HILA, IDLE);
      }  
      else
     
       /* 
        * Send the ICMP-Message later on after ready indication
        */
      
        p_ker->send_icmp = TRUE;       
    }
    break;
  
  default:
    break;
  }

  /* 
   * Free and stop the timer 
   */
  p_dl->timer_reass_running[p_dl->pos_server] = FALSE;
}

/*
+--------------------------------------------------------------------+
| PROJECT : GSM-FaD (8411)               MODULE  : IP_TIM            |
| STATE   : code                         ROUTINE : tim_init_timer    |
+--------------------------------------------------------------------+

  PURPOSE : Initialise Time-out FIFO and configuration data.

*/

GLOBAL BOOL tim_init_timer (void)
{
  return TRUE;
}

/*
+--------------------------------------------------------------------+
| PROJECT : GSM-FaD (8411)        MODULE  : IP_TIM                   |
| STATE   : code                  ROUTINE : tim_set_timeout_flag     |
+--------------------------------------------------------------------+

  PURPOSE : Set timeout flag according to timer handle

*/
/*
+--------------------------------------------------------------------+
| PROJECT : GSM-FaD (8411)        MODULE  : IP_TIM                   |
| STATE   : code                  ROUTINE : tim_flush_fifo           |
+--------------------------------------------------------------------+

  PURPOSE : Flush timer fifo for timer handle

*/
/*
+--------------------------------------------------------------------+
| PROJECT : GSM-FaD (8411)        MODULE  : IP_TIM                   |
| STATE   : code                  ROUTINE : tim_handle_timeout       |
+--------------------------------------------------------------------+

  PURPOSE : execute timeout function depending on t_flag

*/