FreeCalypso > hg > fc-magnetite
view src/g23m-fad/tcpip/include/atp_config.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 90eb61ecd093 |
| children |
line wrap: on
line source
/******************************************************************************* * * File Name : atp_config.h * * Configuration setting of ATP SW entity * * (C) Texas Instruments, all rights reserved * * Version number : 0.1 Date : 28-Feb-2000 * * History : 0.1 - Created by E. Baissus * * * Author : Eric Baissus : e-baissus@ti.com * * (C) Copyright 2000 by Texas Instruments Incorporated, All Rights Reserved ******************************************************************************/ #ifndef ATP_CONFIG_H #define ATP_CONFIG_H #include "rvf_pool_size.h" /* Stack & Memory Bank sizes definitions */ /* Maximum number of SW entity which can register simultaneously register to the ATP SW entity */ #define ATP_MAX_NB_SW_ENTITY 10 // This does not includes GSM SW entity #define ATP_SW_ENTITY_NAME_MAX_CARAC 10 #define ATP_SPP_MAX_PENDING_PORT 10 /* Maximum number of port which can be in open port pending state at the same time Note that a port is considered to be in pending state when in server mode */ #define ATP_HSG_NAME "HSG" /* Sw entity name : used to register to ATP the HSG*/ #define ATP_GSM_NAME "GSM" /* Sw entity name of the GSM-PS used to register to the ATP */ #define ATP_SPP_NAME "SPP" /* Sw entity name : used to register to ATP the SPP */ #define ATP_HS_NAME "HS" /* Sw entity name : used to register to ATP the HS */ #define ATP_AAA_NAME "AAA" /* Sw entity name of the GSM-PS used to register to the ATP */ #define ATP_DEFAULT_GSM_MAX_PACKET_SIZE (1500) // Default value indicating the maximum size that is supported // when GSM sends a packet to ATP #define ATP_MAX_NB_OF_PORT_SUPPORTED_BY_GSM (3) #define ATP_MAX_CMD_LENGTH (0xFF) // Maximum length of a command handled by ATP /* Configuration parameters for environment */ #define ATP_MB_PRIM_SIZE RVF_ATP_MB1_SIZE #define ATP_MB_PRIM_WATERMARK (ATP_MB_PRIM_SIZE - 1000) /* ** This def is in rvm_priorities.h ** #define ATP_SWE_LEVEL (4); // SHOULD BE DEFINED IN RVM_PRIORITIES.H !!! */ #endif