FreeCalypso > hg > fc-magnetite

view src/g23m-fad/tcpip/include/general.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 90eb61ecd093
children
line wrap: on
line source

/****************************************************************************/
/*                                                                          */
/*  Name        general.h                                                   */
/*                                                                          */
/*  Function    this file contains common data type definitions used        */
/*              throughout the SWE                                          */
/*                                                                          */
/*  Date       Modification                                                 */
/*  -----------------------                                                 */
/*  3/12/99    Create                                                       */
/* **************************************************************************/
/*  10/27/1999 David Lamy-Charrier: remove declaration of ntohs, htons,     */
/*                                  ntohl, htonl in order to avoid conflict */
/*                                  with winsock.h                          */
/*                                                                          */
/*  11/30/1999 Pascal Pompei: 'string.h' included in order to define memcmp,*/
/*                            memset and memcpy functions.                  */
/*                                                                          */
/*                                                                          */
/****************************************************************************/

#ifndef GENERAL_H
#define GENERAL_H

#ifdef _WINDOWS
   #include <string.h>
#endif

/* WINDOWS */
#ifdef _WINDOWS
   typedef unsigned short UINT16;
   typedef unsigned int UINT32;
   typedef unsigned char UBYTE;
   typedef short SHORT;
   typedef int BOOL;

/* BOARD */
#else
   #ifndef __TYPEDEFS_H__ /* This #define allows to Condat to use general.h without conflict */
      typedef unsigned short UINT16;
      typedef unsigned char UBYTE;
      typedef short SHORT;
      typedef signed char BYTE;
      #if !defined (BOOL_FLAG)
         #define BOOL_FLAG
         typedef unsigned char BOOL;
      #endif
      typedef unsigned short USHORT;
      typedef unsigned int ULONG;
   #endif
   typedef unsigned long UINT32;
#endif

typedef unsigned char UINT8;
typedef signed char INT8;
typedef short INT16;
typedef int INT32;
typedef unsigned char BOOLEAN;

typedef void (*FUNC)(void); /* pointer to a function */

#define OK 1

#ifndef NULL
   #define NULL 0
#endif

#ifndef TRUE
   #define TRUE 1
#endif

#ifndef FALSE
   #define FALSE 0
#endif

#define htons ntohs
#define htonl ntohl

#if !defined(_WIN32)
   #define ntohs(n) (n)
   #define ntohl(n) (n)
   #define ntoh6(n) (n)
#endif

#endif /* #ifndef GENERAL_H */