FreeCalypso > hg > fc-magnetite
view src/g23m-fad/tcpip/include/rvm_ext_priorities.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 90eb61ecd093 |
| children |
line wrap: on
line source
/************************************************************************************* * * * Name rvm_ext_priorities.h * * * * Function this file priorities defintitions for basic SWEs * * It includes a file * * * Version 0.1 * * * * Date Modification * * ------------------------------------ * * 10/11/2000 Create * * * * Author Cristian Livadiotti (c-livadiotti@ti.com) * * * * (C) Copyright 2000 by Texas Instruments Incorporated, All Rights Reserved * * * * --------------------------------------------------------------------------------- * * * * History: * * * * 10/18/2001 - Updated for R2D by Christophe Favergeon * * * *************************************************************************************/ #ifndef __RVM_EXT_PRIORITIES_H_ #define __RVM_EXT_PRIORITIES_H_ /* PRIORITIES SETTING: */ /* All user priority should be set under 250: */ /* Higher values are reserved */ /* ** External Priority definitions */ #define RVM_EXPL_TASK_PRIORITY (240) #define RVM_OBX_TASK_PRIORITY (240) #define RVM_OPP_TASK_PRIORITY (240) #define RVM_SYN_TASK_PRIORITY (240) #define RVM_FTP_TASK_PRIORITY (240) #define RVM_RGUI_TASK_PRIORITY (240) #define RVM_R2D_TASK_PRIORITY (239) #define RVM_DEV1_TASK_PRIORITY (245) #define RVM_DEV2_TASK_PRIORITY (245) #define RVM_DEV3_TASK_PRIORITY (245) #define RVM_UVM_TASK_PRIORITY (245) #endif /* __RVM_EXT_PRIORITIES_H_ */