FreeCalypso > hg > fc-magnetite

view src/g23m-fad/tcpip/rnet/rnet_atp_info.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 90eb61ecd093
children
line wrap: on
line source

/**
 * @file    rnet_atp_info.h
 *
 * ATP point-to-point network interface for RNET_RT
 * Custom information
 *
 * @author  Regis Feneon
 * @version 0.1
 */

/*
 * $Id: rnet_atp_info.h,v 1.1 2002/09/06 08:39:52 rf Exp $
 * $Name:  $
 *
 * History:
 *
 *  Date        Author        Modification
 *  --------------------------------------------------
 *  6/9/2002    Regis Feneon  Create
 *
 */
#include "rnet_cfg.h"
#ifdef RNET_CFG_REAL_TRANSPORT

#ifndef __RNET_RT_ATP_INFO_H_
#define __RNET_RT_ATP_INFO_H_

#include "rnet_ip_addr.h"
#include "dcfg_api.h"

#define RNET_RT_ATP_MTU 1500

/** ATP custom information */
typedef struct {

  T_ATP_CUSTOM_TYPE custom_type;
  /** local (MS) IP address */
  T_RNET_IP_ADDR local_addr;
  /** destination (GGSN) IP address, this is also the default router */
  T_RNET_IP_ADDR dest_addr;
  /** maximum transmission unit */
  UINT16 mtu;
  /** primary DNS server address */
  T_RNET_IP_ADDR dns1;
  /** secondary DNS server address */
  T_RNET_IP_ADDR dns2;
  /* Identity of the user of the channel */
  T_APPLI_USER IPU_id;
} T_RNET_RT_ATP_CUSTOM_INFO;

#endif
#endif