FreeCalypso > hg > fc-magnetite

view src/g23m-fad/tcpip/rnet/rnet_cfg.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 90eb61ecd093
children
line wrap: on
line source

/**
 * @file  rnet_cfg.h
 *
 * Riviera NET.
 *
 * Configuration definitions for the RNET instance.
 *
 * @author  Vincent Oberle (v-oberle@ti.com)
 * @version 0.1
 */

/*
 * History:
 *
 *   Date         Author        Modification
 *  --------------------------------------------------
 *  01/29/2002  Vincent Oberle    Create
 *
 * (C) Copyright 2002 by Texas Instruments Incorporated, All Rights Reserved
 */

#ifndef __RNET_CFG_H_
#define __RNET_CFG_H_

#include "rv_defined_swe.h"

/**
 * RNET underlying implementation.
 *
 * In normal usage, this doesn't need to be modified.
 * rv_defined_swe.h takes care to check that only one of the
 * RVM_RNET_xx_SWE is defined.
 */
#ifdef RVM_RNET_WS_SWE
  #define RNET_CFG_WINSOCK
#endif
#ifdef RVM_RNET_BR_SWE
  #define RNET_CFG_BRIDGE
#endif
#ifdef RVM_RNET_RT_SWE
  #ifndef RNET_CFG_REAL_TRANSPORT
    #define RNET_CFG_REAL_TRANSPORT
  #endif  /* RNET_CFG_REAL_TRANSPORT */
#endif

/**
 * Maximum size that a host name can have.
 * Increase this value to be sure not to get a truncated host name
 */
#define RNET_MAX_HOST_NAME_LEN 100 /* should be 255 see RFC... */

/**
 * Use the Loopback interface.
 */
#define RNET_RT_LOOPBACK_SUPPORT

#endif /* __RNET_CFG_H_ */