FreeCalypso > hg > fc-magnetite

view src/g23m-fad/tcpip/rnet/rnet_ip_addr.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 90eb61ecd093
children
line wrap: on
line source

/**
 * @file  ipv4/rnet_ip_addr.h
 *
 * Riviera NET.
 *
 * IPv4 address related structures.
 * See the Readme.txt file.
 *
 * @author  Vincent Oberle (v-oberle@ti.com)
 * @version 0.1
 */

/*
 * History:
 *
 *   Date         Author        Modification
 *  --------------------------------------------------
 *  01/25/2002  Vincent Oberle    Create
 *
 * (C) Copyright 2002 by Texas Instruments Incorporated, All Rights Reserved
 */

#ifndef __RNET_IP_ADDR_H_
#define __RNET_IP_ADDR_H_

#include "rv_general.h"

#ifdef __cplusplus
extern "C"
{
#endif

/**
 * @name  IPv4 address.
 *
 * T_RNET_IP_ADDR is the IPv4 address type.
 *
 * The RNET_IP_ADDR_ANY value corresponds to any IP address.
 * The RNET_IP4_ADDR allows easy creation of IP addresses.
 */
/*@{*/
typedef UINT32 T_RNET_IP_ADDR;

#define RNET_IP_ADDR_ANY 0

#define RNET_IP4_ADDR(ipaddr, a,b,c,d) { \
  ipaddr = ((UINT32)(a & 0xff) << 24) | ((UINT32)(b & 0xff) << 16) | \
       ((UINT32)(c & 0xff) << 8) | (UINT32)(d & 0xff); \
}
/*@}*/

/**
 * Port. 16 bits.
 */
typedef UINT16 T_RNET_PORT;

#ifdef __cplusplus
}
#endif

#endif /* __RNET_IP_ADDR_H_ */