FreeCalypso > hg > fc-magnetite

view src/g23m-fad/tcpip/rnet/rnet_trace.c @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 90eb61ecd093
children
line wrap: on
line source

/**
 * @file  rnet_trace.c
 *
 * Riviera NET.
 *
 * PC trace functions. Only under Riviera Tool.
 *
 * @author  Vincent Oberle (v-oberle@ti.com)
 * @version 0.1
 */

/*
 * History:
 *
 *   Date         Author        Modification
 *  --------------------------------------------------
 *  01/30/2002  Vincent Oberle    Create
 *
 * (C) Copyright 2002 by Texas Instruments Incorporated, All Rights Reserved
 */

#include "rnet_trace_i.h"

#ifdef RNET_TRACE_RET

/**
 * Traces the return value of RNET API functions.
 */
void rnet_trace_ret (T_RNET_RET ret)
{
  switch (ret) {
  case RNET_OK:
    //RNET_TRACE_LOW("RNET: OK");
    break;
  case RNET_MEMORY_ERR:
    RNET_TRACE_LOW("RNET: MEMORY_ERR");
    break;
  case RNET_INVALID_PARAMETER:
    RNET_TRACE_LOW("RNET: INVALID_PARAMETER");
    break;
  case RNET_NOT_SUPPORTED:
    RNET_TRACE_LOW("RNET: NOT_SUPPORTED");
    break;
  case RNET_NOT_READY:
    RNET_TRACE_LOW("RNET: NOT_READY");
    break;
  case RNET_INTERNAL_ERR:
    RNET_TRACE_LOW("RNET: INTERNAL_ERR");
    break;
  case RNET_IN_USE:
    RNET_TRACE_LOW("RNET: IN_USE");
    break;
  case RNET_NOT_INITIALIZED:
    RNET_TRACE_LOW("RNET: NOT_INITIALIZED");
    break;
  case RNET_NET_UNREACHABLE:
    RNET_TRACE_LOW("RNET: NET_UNREACHABLE");
    break;
  case RNET_TIMEOUT:
    RNET_TRACE_LOW("RNET: TIMEOUT");
    break;
  case RNET_CONN_REFUSED:
    RNET_TRACE_LOW("RNET: CONN_REFUSED");
    break;
  case RNET_CONN_RESET:
    RNET_TRACE_LOW("RNET: CONN_RESET");
    break;
  case RNET_CONN_ABORTED:
    RNET_TRACE_LOW("RNET: CONN_ABORTED");
    break;
  case RNET_CONN_CLOSED:
    RNET_TRACE_LOW("RNET: CONN_CLOSED");
    break;
  case RNET_MSG_SIZE:
    RNET_TRACE_LOW("RNET: MSG_SIZE");
    break;
  case RNET_PARTIAL_SENT:
    RNET_TRACE_LOW("RNET: PARTIAL_SENT");
    break;
  case RNET_HOST_NOT_FOUND:
    RNET_TRACE_LOW("RNET: HOST_NOT_FOUND");
    break;

  default:
    RNET_TRACE_MEDIUM_PARAM("RNET: Unknown return value: ", ret);
  }
}

#endif