FreeCalypso > hg > fc-magnetite

view src/g23m-gprs/cl/cl_nwrl.c @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 219afcfc6250
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GPRS (8441)
|  Module  :  CL
|  File    :  cl_nwrl.c
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  This file implements common library functions related to the
|             network release(in this case, SGSN release) for all entities of 
|             the GPRS protocol stack
+----------------------------------------------------------------------------- 
*/ 

#ifndef CL_NWRL_C
#define CL_NWRL_C
#endif

/*==== INCLUDES =============================================================*/

#include "typedefs.h"    /* to get Condat data types */
#include "vsi.h"
#include "p_cl.val"  /* to get the type of sgsn_rel*/
#include "p_8010_152_ps_include.h" /*to get T_PS_qos_rXX*/
#include "cl_inline.h"

LOCAL U8 sgsn_release;

/*
+------------------------------------------------------------------------------
| Function    : cl_nwrl_set_sgsn_release() 
+------------------------------------------------------------------------------
| Description : The function cl_nwrl_set_sgsn_release() sets the status of SGSN 
|               release as received in SI13, PSI1 and PSI13 messages. This is 
|               called by GRR during initialization after Power On, when 
|               processing SI13, PSI1 and PSI13
|
| Parameters  : U8 sgsn_rel
|
+------------------------------------------------------------------------------
*/

GLOBAL void cl_nwrl_set_sgsn_release(U8 sgsn_rel)
{
  TRACE_FUNCTION( "cl_nwrl_set_sgsn_release()" );
  sgsn_release = sgsn_rel;
}


/*
+------------------------------------------------------------------------------
| Function    : cl_nwrl_get_sgsn_release()
+------------------------------------------------------------------------------
| Description : The function cl_nwrl_get_sgsn_release() gets the status of SGSN
|               release. This is called up by entities such as GMM, SM that need
|               the SGSN release. It is advised to call this function only after
|               a cell re-selection as the SGSN release value is invalid during
|               cell re-selection.
|
| Parameters  : Nil
|
+------------------------------------------------------------------------------
*/

GLOBAL U8 cl_nwrl_get_sgsn_release()
{
  TRACE_FUNCTION( "cl_nwrl_get_sgsn_release()" );
  return sgsn_release;
}