FreeCalypso > hg > fc-magnetite

view src/g23m-gprs/gmm/gmm_f.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 219afcfc6250
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GPRS (8441)
|  Modul   :  gmm_f.h
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions for gmm_f.c 
+----------------------------------------------------------------------------- 
*/ 


#ifndef GMM_F_H
#define GMM_F_H

/*
 * gmm data debug print mask
 * select type of information for debug print 
 */
enum
{
   GMM_DEBUG_PRINT_MASK_FULL          = 0x0fff, /*                   */
   //
   GMM_DEBUG_PRINT_MASK_COMMON        = 0x0001, /* 00000000 00000001 */
   GMM_DEBUG_PRINT_MASK_TIMER         = 0x0002, /* 00000000 00000010 */
   GMM_DEBUG_PRINT_MASK_STATE         = 0x0004, /* 00000000 00000100 */
   GMM_DEBUG_PRINT_MASK_TLLI          = 0x0008, /* 00000000 00001000 */
   GMM_DEBUG_PRINT_MASK_IMSI          = 0x0010, /* 00000000 00010000 */
   GMM_DEBUG_PRINT_MASK_PTMSI         = 0x0020, /* 00000000 00100000 */
   GMM_DEBUG_PRINT_MASK_CID           = 0x0040, /* 00000000 01000000 */
   GMM_DEBUG_PRINT_MASK_RAI           = 0x0080, /* 00000000 10000000 */
   //
   GMM_DEBUG_PRINT_MASK_KERN          = 0x0100, /* 00000001 00000000 */
   GMM_DEBUG_PRINT_MASK_KERN_ATTACH   = 0x0200, /* 00000010 00000000 */

	GMM_DEBUG_PRINT_MASK_END,
	GMM_DEBUG_PRINT_MASK_MAX = (GMM_DEBUG_PRINT_MASK_END - 1)
};
typedef U32 GMM_DEBUG_PRINT_MASK_ENUM_TYPE;

EXTERN void gmm_debug_do_print_gmm_data(GMM_DEBUG_PRINT_MASK_ENUM_TYPE print_mask);
#ifdef WIN32
#define GMM_TRACE_GMM_DATA(m) gmm_debug_do_print_gmm_data(m)
#else
#define GMM_TRACE_GMM_DATA(m)
#endif

EXTERN ULONG gmm_get_tlli ( T_TLLI_TYPE tlli_type );

EXTERN void gmm_set_current_tlli ( T_TLLI_TYPE tlli_type );

#endif /* GMM_F_H */