FreeCalypso > hg > fc-magnetite

view src/g23m-gprs/gmm/gmm_kerns.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 219afcfc6250
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GPRS (8441)
|  Modul   :  gmm_kerns.h
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions for gmm_kerns.c 
+----------------------------------------------------------------------------- 
*/ 

#ifndef GMM_KERNS_H
#define GMM_KERNS_H


EXTERN void sig_auth_kern_abort_ind ( void );



EXTERN void sig_auth_kern_dereg_ind ( void );



EXTERN void sig_rx_kern_att_acc_ind ( void );



EXTERN void sig_rx_kern_att_rej_ind ( void );



EXTERN void sig_rx_kern_det_req_ind ( void );



EXTERN void sig_rx_kern_det_acc_ind ( void );



EXTERN void sig_rx_kern_rau_acc_ind ( void );



EXTERN void sig_rx_kern_rau_rej_ind ( void );


EXTERN void sig_rx_kern_realloc_cmd_ind ( void );

EXTERN void sig_rx_kern_auth_req_ind ( void );
EXTERN void sig_rx_kern_auth_rej_ind ( void );
EXTERN void sig_rx_kern_id_req_ind ( void );
EXTERN void sig_rx_kern_status_ind ( void );
EXTERN void sig_rx_kern_info_ind ( void );
EXTERN void sig_rx_kern_tst_cmd_ind ( void );
#ifdef GMM_TCS4
  #ifdef FF_EGPRS
    EXTERN void sig_rx_kern_egprs_loopb_cmd_ind ( void );
  #endif /*FF_EGPRS*/
#endif /*GMM_TCS4*/

EXTERN void sig_sync_kern_cell_ind ( T_SIG_CELL_INFO * sig_cell_info );
EXTERN void sig_sync_kern_mmgmm_nreg_ind ( T_MMGMM_NREG_IND *mmgmm_nreg_ind );
EXTERN void sig_sync_kern_mmgmm_reg_rej ( T_MMGMM_REG_REJ *mmgmm_reg_rej );
EXTERN void sig_sync_kern_mmgmm_reg_cnf ( T_MMGMM_REG_CNF *mmgmm_reg_cnf );
EXTERN void sig_rdy_kern_cu_ind ( void );




#endif /* !GMM_KERNS_H */