FreeCalypso > hg > fc-magnetite

view src/g23m-gprs/grlc/grlc_func.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 219afcfc6250
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GPRS (8441)
|  Modul   :  GRLC
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions for grlc_func.c. Only in Target used. 
+----------------------------------------------------------------------------- 
*/ 

#ifndef GRLC_FUNC_H
#define GRLC_FUNC_H

/* 
 * Mapping of TI-types to Condat-types
 */
#define UWORD8    UBYTE
#define WORD8     UBYTE
#define WORD16    SHORT
#define UWORD16   USHORT
#define UWORD32   ULONG
#define API       USHORT 

EXTERN void maca_power_control ( UWORD8  assignment_id,
                                 BOOL    crc_error,
                                 WORD8   bcch_level,
                                 UWORD16 radio_freq[MAC_BURST_PER_BLOCK],
                                 WORD8   burst_level[MAC_BURST_PER_BLOCK],
                                 UWORD8 *pch );

#ifdef _TARGET_

EXTERN void rlc_uplink ( UWORD8   assignment_id,
                         UWORD8   tx_data_no,
                         UWORD32  fn,
                         UWORD8   timing_advance_value,
                         T_ul_poll_resp    * ul_poll_response,
                         T_ul_data         * ul_data, 
                         BOOL      allocation_exhausted);


EXTERN void rlc_downlink ( UWORD8         assignment_id,
                           UWORD32        fn,
                           T_dl_struct   *data_ptr,
                           UWORD8         rlc_blocks_sent,
                           UWORD8         last_poll_response);
#endif /* _TARGET_*/


#endif /* !GRLC_FUNC_H */