FreeCalypso > hg > fc-magnetite

view src/g23m-gprs/grlc/grlc_tms.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 219afcfc6250
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GPRS (8441)
|  Modul   :  GRLC
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions for service TM.
+----------------------------------------------------------------------------- 
*/ 

#ifndef GRLC_TMS_H
#define GRLC_TMS_H



/*
 *  interface for service RU
 */
EXTERN void sig_ru_tm_error_ra( void );
EXTERN void sig_ru_tm_cs( void );
EXTERN void sig_ru_tm_end_of_tbf( void );
EXTERN void sig_ru_tm_end_of_pdu ( UBYTE );
EXTERN void sig_ru_tm_prim_delete ( void );
EXTERN void sig_ru_tm_ctrl_blk_sent( UBYTE index );
#if defined REL99 AND defined TI_PS_FF_TBF_EST_PACCH
EXTERN void sig_ru_tm_ul_re_est_tbf(void);
#endif

/*
 *  interface for service RD
 */
EXTERN void sig_rd_tm_end_of_tbf( BOOL rel_ul );
EXTERN void sig_rd_tm_ul_req_cnf( void );


EXTERN UBYTE* tm_get_ctrl_blk(UBYTE *index, BOOL unacknowledged);
EXTERN BOOL   tm_is_ctrl_blk_rdy(UBYTE ack_cnt_meas_rpt, UBYTE ack_cnt_other);
EXTERN UBYTE  tm_get_num_ctrl_blck(void);
EXTERN UBYTE  tm_cpy_ctrl_blk_to_buffer(UBYTE *buffer);

EXTERN void sig_ru_tm_repeat_alloc( void );
EXTERN void   sig_ru_tm_end_of_fix_alloc(void);

#if defined REL99 AND defined TI_PS_FF_TBF_EST_PACCH
EXTERN void sig_gff_tm_mac_ready_ind_two_phase  (T_MAC_READY_IND *mac_ready_ind);
EXTERN void tm_send_prr_2p_ptm ( void );
#endif


#endif /* !GRLC_TMS_H */