FreeCalypso > hg > fc-magnetite

view src/g23m-gprs/llc/llc_irxf.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 219afcfc6250
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  
|  Modul   :  
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions for llc_irxf.c
+----------------------------------------------------------------------------- 
*/ 

#ifndef LLC_IRXF_H
#define LLC_IRXF_H


EXTERN void irx_init            (void);
EXTERN void irx_init_sapi       (void);
EXTERN void irx_init_abm        (void);

EXTERN void irx_queue_store     (T_LL_UNITDATA_IND *ll_unitdata_ind,  
                                 T_FRAME_NUM       ns,
                                 BOOL              *is_busy);
EXTERN void irx_queue_retrieve  (T_LL_UNITDATA_IND **ll_unitdata_ind, BOOL* found);
EXTERN void irx_queue_clean     (void);
EXTERN void irx_get_last_queued_ns (BOOL *found, T_FRAME_NUM *num);

EXTERN void irx_update_vr       (void);
EXTERN void irx_ack_all_to      (T_FRAME_NUM n);
EXTERN void irx_handle_sack     (T_FRAME_NUM nr, T_LL_UNITDATA_IND*, T_PDU_TYPE);
EXTERN void irx_send_ack        (T_BIT a_bit);
EXTERN void irx_send_rnr        (void);

EXTERN void irx_build_sack_bitmap (T_SACK_BITMAP *bitmap);

#endif /* !LLC_IRXF_H */