FreeCalypso > hg > fc-magnetite

view src/g23m-gprs/llc/llc_itxf.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 219afcfc6250
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  
|  Modul   :  
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions for llc_itxf.c 
+----------------------------------------------------------------------------- 
*/ 

#ifndef LLC_ITXF_H
#define LLC_ITXF_H


EXTERN void itx_init               (void);

EXTERN void itx_init_sapi          (void);

EXTERN void itx_send_next_frame    (T_ABIT_REQ_TYPE req);

EXTERN void itx_i_queue_clean      (void);

EXTERN void itx_i_queue_store      
(
#ifdef LL_DESC
 T_LL_DESC_REQ*, BOOL *store_failed
#else
 T_LL_DATA_REQ*, BOOL *store_failed
#endif
);
EXTERN void itx_i_queue_set_status (T_IQ_STATUS status, T_FRAME_NUM num);

#ifdef LL_2to1
EXTERN void itx_i_queue_get_ready  (BOOL* found, T_LL_reference1* reference, UBYTE state);
#else
EXTERN void itx_i_queue_get_ready  (BOOL* found, T_reference1* reference, UBYTE state);
#endif

#ifdef LL_2to1
EXTERN void itx_send_ll_data_cnf   (T_LL_reference1* reference);
#else
EXTERN void itx_send_ll_data_cnf   (T_reference1* reference);
#endif

EXTERN void itx_handle_ll_ready_ind(BOOL data_send);

EXTERN void itx_s_queue_store      (T_COMMAND, T_ABIT_REQ_TYPE, T_FRAME_NUM nr, 
                                    T_SACK_BITMAP*);

EXTERN void itx_s_queue_clean      (void);


#endif /* !LLC_ITXF_H */