FreeCalypso > hg > fc-magnetite

view src/g23m-gprs/sm/sm_mm_output_handler.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 219afcfc6250
children
line wrap: on
line source

/*----------------------------------------------------------------------------
|  Project :  3G PS
|  Module  :  SM
+-----------------------------------------------------------------------------
|             Copyright 2003 Texas Instruments.
|             All rights reserved. 
| 
|             This file is confidential and a trade secret of Texas 
|             Instruments .
|             The receipt of or possession of this file does not convey 
|             any rights to reproduce or disclose its contents or to 
|             manufacture, use, or sell anything it may describe, in 
|             whole, or in part, without the specific written consent of 
|             Texas Instruments. 
+-----------------------------------------------------------------------------
| Purpose:    Output functions for primitives from SM to the MM entity.
|             For design details, see:
|             8010.908 SM Detailed Specification
+---------------------------------------------------------------------------*/

/*==== DECLARATION CONTROL =================================================*/

#ifndef SM_MM_OUTPUT_HANDLER_H
#define SM_MM_OUTPUT_HANDLER_H

/*==== INCLUDES =============================================================*/

#include "sm.h"

/*==== CONSTS ===============================================================*/

/*==== TYPES ================================================================*/

/*==== EXPORTS ==============================================================*/

/* Primitive sending functions */
extern void send_mmpm_pdp_context_status_req(void);

#if 0 /* Not used directly - only by message sending functions below */
extern void send_mmpm_unitdata_req(U8 ti, U8 est_cause, /*@only@*/ /*@null@*/T_MMPM_UNITDATA_REQ *prim);
#endif
extern void resend_msg(struct T_SM_CONTEXT_DATA *context);

/* Air Interface Message formatting functions */
extern void send_msg_activate_pdp_context_request(struct T_SM_CONTEXT_DATA *context);
extern void send_msg_activate_secondary_pdp_context_request(struct T_SM_CONTEXT_DATA *context);
extern void send_msg_deactivate_pdp_context_accept(struct T_SM_CONTEXT_DATA *context);
extern void send_msg_deactivate_pdp_context_request(struct T_SM_CONTEXT_DATA *context, /*@partial@*/T_CAUSE_ps_cause *cause, BOOL tear_down);
extern void send_msg_modify_pdp_context_accept(struct T_SM_CONTEXT_DATA *context);
extern void send_msg_modify_pdp_context_request(struct T_SM_CONTEXT_DATA *context);
extern void send_msg_request_pdp_context_activation_reject(struct T_SM_CONTEXT_DATA *context, /*@partial@*/T_CAUSE_ps_cause *cause);
extern void send_msg_sm_status(U8 ti, /*@partial@*/T_CAUSE_ps_cause *cause);

#endif /* SM_MM_OUTPUT_HANDLER_H */
/*==== END OF FILE ==========================================================*/