FreeCalypso > hg > fc-magnetite

view src/g23m-gprs/sndcp/sndcp_nds.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 219afcfc6250
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GPRS (8441)
|  Modul   :  sndcp_nds.h
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions for sndcp_nds.c 
+----------------------------------------------------------------------------- 
*/ 

#ifndef SNDCP_NDS_H
#define SNDCP_NDS_H

EXTERN void sig_mg_nd_recover (UBYTE nsapi);

EXTERN void sig_mg_nd_reset_ind (UBYTE nsapi);

#ifdef SNDCP_UPM_INCLUDED
EXTERN U8 sig_mg_nd_get_rec_no(UBYTE nsapi);
#else
EXTERN void sig_mg_nd_get_rec_no(UBYTE nsapi);
#endif

EXTERN void sig_mg_nd_resume (UBYTE nsapi);

EXTERN void sig_mg_nd_suspend (UBYTE nsapi);

EXTERN void sig_sd_nd_unitdata_ind (UBYTE nsapi,
                                    T_SN_UNITDATA_IND* sn_unitdata_ind);

EXTERN void sig_sda_nd_data_ind (UBYTE nsapi,
                                 T_SN_DATA_IND* sn_data_ind,
                                 UBYTE npdu_number);

EXTERN void sndcp_reset_nd_nsapi_npdu_num (UBYTE nsapi); 

#endif /* !SNDCP_NDS_H */