FreeCalypso > hg > fc-magnetite

view src/g23m-gsm/l1/l1.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 27a4235405c6
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  
|  Modul   :  
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions for the Protocol Stack Entity l1.
+----------------------------------------------------------------------------- 
*/ 

#ifndef L1_H
#define L1_H

#ifdef TI_PS_HCOMM_CHANGE
#include "cl_hComm_handle.h"

#ifdef NEW_FRAME


  #define hCommGRR              l1_hCommGRR
  #define hCommLLC              l1_hCommLLC
  #define hCommSNDCP            l1_hCommSNDCP
  #define hCommGMM              l1_hCommGMM
  #define hCommTOM              l1_hCommTOM

  #define L1_Handle             l1_L1_Handle
   
/*jk: delete warnings  #define VSI_CALLER L1_Handle, */

  #ifdef L1_PEI_C

    /* Communication handles */

  #ifdef GPRS
    T_HANDLE                 hCommGRR = VSI_ERROR;
    T_HANDLE                 hCommLLC = VSI_ERROR;
    T_HANDLE                 hCommSNDCP = VSI_ERROR;
    T_HANDLE                 hCommGMM = VSI_ERROR;
    T_HANDLE                 hCommTOM = VSI_ERROR;
  #endif	
    T_HANDLE                 L1_Handle;

  #else /* L1_PEI_C */

    extern T_HANDLE          hCommGRR;
    extern T_HANDLE          hCommLLC;
    extern T_HANDLE          hCommSNDCP;
    extern T_HANDLE          hCommGMM;
    extern T_HANDLE          hCommTOM;
    extern T_HANDLE          L1_Handle;

  #endif /* L1_PEI_C */

#else /* NEW_FRAME */

  #define PL_NAME    "PL"
  #define L1_NAME    "L1"
 
  #define VSI_CALLER L1_NAME,

#endif /* NEW_FRAME */
#else
#ifdef NEW_FRAME

  #define hCommPL               l1_hCommPL
  #define hCommL1               l1_hCommL1
  #define hCommGRR              l1_hCommGRR
  #define hCommLLC              l1_hCommLLC
  #define hCommSNDCP            l1_hCommSNDCP
  #define hCommGMM              l1_hCommGMM
  #define hCommTOM              l1_hCommTOM
  #define hCommACI              l1_hCommACI
  #define L1_Handle             l1_L1_Handle
   
/*jk: delete warnings  #define VSI_CALLER L1_Handle, */

  #ifdef L1_PEI_C

    /* Communication handles */
    T_HANDLE                 hCommPL = VSI_ERROR;
    T_HANDLE                 hCommACI = VSI_ERROR;
    T_HANDLE                 hCommL1 = VSI_ERROR;
  #ifdef GPRS
    T_HANDLE                 hCommGRR = VSI_ERROR;
    T_HANDLE                 hCommLLC = VSI_ERROR;
    T_HANDLE                 hCommSNDCP = VSI_ERROR;
    T_HANDLE                 hCommGMM = VSI_ERROR;
    T_HANDLE                 hCommTOM = VSI_ERROR;
  #endif	
    T_HANDLE                 L1_Handle;

  #else /* L1_PEI_C */

    extern T_HANDLE          hCommPL;
    extern T_HANDLE          hCommACI;
    extern T_HANDLE          hCommL1;
    extern T_HANDLE          hCommGRR;
    extern T_HANDLE          hCommLLC;
    extern T_HANDLE          hCommSNDCP;
    extern T_HANDLE          hCommGMM;
    extern T_HANDLE          hCommTOM;
    extern T_HANDLE          L1_Handle;

  #endif /* L1_PEI_C */

#else /* NEW_FRAME */

  #define PL_NAME    "PL"
  #define L1_NAME    "L1"
 
  #define VSI_CALLER L1_NAME,

  #ifdef L1_PEI_C
  
    T_VSI_CHANDLE            hCommPL = VSI_ERROR;
    T_VSI_CHANDLE            hCommL1 = VSI_ERROR;

  #else /* L1_PEI_C */

    extern T_VSI_CHANDLE     hCommPL;
    extern T_VSI_CHANDLE     hCommL1;

  #endif /* L1_PEI_C */

#endif /* NEW_FRAME */
#endif /* TI_PS_HCOMM_CHANGE */
#endif /* L1_H */