FreeCalypso > hg > fc-magnetite

view src/gpf2/ccd/ccd_inc.mk @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 864b8cc0cf63
children
line wrap: on
line source

#----------------------------------------------------------------------------- 
#  Project :  
#  Modul   :  ccd_inc.mk
#----------------------------------------------------------------------------- 
#  Copyright 2002 Texas Instruments Berlin, AG 
#                 All rights reserved. 
# 
#                 This file is confidential and a trade secret of Texas 
#                 Instruments Berlin, AG 
#                 The receipt of or possession of this file does not convey 
#                 any rights to reproduce or disclose its contents or to 
#                 manufacture, use, or sell anything it may describe, in 
#                 whole, or in part, without the specific written consent of 
#                 Texas Instruments Berlin, AG. 
#----------------------------------------------------------------------------- 
# Purpose : Some general definition also used in CCD\util.
#----------------------------------------------------------------------------- 

#-------------------------Suffixes for the name of the output file
#---------e.g. ccd_tr_rt_po_db.lib

ifdef TOOL_CHOICE
  TSDIR:=/ts$(TOOL_CHOICE)
  tsTail  :=_ts$(TOOL_CHOICE)
else
  TSDIR:=
endif

ifeq ($(TRACE), 1)
   trTail :=_tr
   TRACEDIR=/trace
else 
   trTail:=
   TRACEDIR=
endif

ifeq ($(MEMSUPER), 1)
  PSDIR=/ps
  pstail :=_ps
else
  PSDIR=
  pstail:=
endif

ifeq ($(DEBUG), 1)
   DEBUGDIR=/debug
   dbTail :=_db
else 
   DEBUGDIR=
   dbTail:=
endif

SECTION=
secTail=
ifeq ($(RUN_FLASH), 1)
  SECTION=/fl
  secTail:=_fl
endif
ifeq ($(RUN_INT_RAM), 1)
  SECTION=/ir
  secTail:=_ir
endif

ifeq ($(TARGET), nuc)
   tTail :=_na7
   ifeq ($(PLATFORM), arm7)
      tTail :=_na7
      ifeq ($(DYNARR), 1)
        DADIR=/da
        datail :=_da
      else
        DADIR=
        datail:=
      endif
   else
      ifeq ($(PLATFORM), arm9)
         tTail :=_na9
      else
        ifeq ($(PLATFORM), pc)
           tTail :=_npc
        endif #pc
      endif #arm9
   endif #arm7
else
   ifeq ($(TARGET), win32)
     tTail :=_wn
   else
     ifeq ($(TARGET), linuxpc)
      tTail :=_lpc
      OSENV=sus
     else
       ifeq ($(TARGET), rtlpc)
        tTail :=_rlp
        OSENV=sus
        RTL_VERSION=2.0
        RTL_DIR=/opt/rtldk-$(RTL_VERSION)/rtlinuxpro
        include $(RTL_DIR)/rtl.mk
       else
         ifeq ($(TARGET), linuxarm)
          tTail :=_la9
          OSENV=sus
          else
           ifeq ($(TARGET), solsparc)
            tTail :=_ssp
            OSENV=sus
            BYTESEX=motorola
           endif #solsparc
         endif #linuxarm
       endif #rtlpc
     endif #linuxpc
   endif #win32  
endif #nuc

XXX:=$(tTail)$(trTail)$(dbTail)$(pstail)$(datail)$(secTail)$(tsTail)