FreeCalypso > hg > fc-magnetite

view src/gpf2/inc/alert.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 864b8cc0cf63
children
line wrap: on
line source

/* 
+------------------------------------------------------------------------------
|  File:       alert.h
+------------------------------------------------------------------------------
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  definitions for the ALERT macro.
+----------------------------------------------------------------------------- 
*/ 

#ifndef ALERT_H
#define ALERT_H

#undef ALERT
#undef E_ALERT

#ifndef ALERT_OFF
  #include "typedefs.h"
  #include "vsi.h" 
  
  extern BOOL _Alert(char *, T_HANDLE, ULONG);
  extern BOOL alert_info(char *, ...);
  #define NO_ALERT_INFO alert_info("")

  #define _STR(x) _VAL(x)
  #define _VAL(x) #x
  /*
   * The && FALSE in the end is just to notify the reader that 
   * FALSE is always returned if the predicate evaluates to false.
   */
  #define ALERT(expression, alertclass, function) ((expression) ? ((void) 0) : \
          (void) (_Alert(__FILE__ "(" _STR(__LINE__) ") \"" #expression "\"", VSI_CALLER TC_ALERT_##alertclass) && (function)))
 
  #define E_ALERT(expression, alertclass, function) ((expression) ? (TRUE) : \
          (BOOL)  (_Alert(__FILE__ "(" _STR(__LINE__) ") \"" #expression "\"", VSI_CALLER TC_ALERT_##alertclass) && (function) && FALSE))

#else /* ALERT_OFF */
  #define NO_ALERT_INFO (0)
  #define ALERT(expression, alertclass, function)   ((void) 0)
  #define E_ALERT(expression, alertclass, function) (expression)
#endif /* ALERT_OFF */

#endif /* ALERT_H */