FreeCalypso > hg > fc-magnetite

view src/gpf2/inc/nuc/os_glob.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 864b8cc0cf63
children
line wrap: on
line source

/* 
+------------------------------------------------------------------------------
|  File:       os_glob.h
+------------------------------------------------------------------------------
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Global tabless for the Nucleus OS adaptation layer
+----------------------------------------------------------------------------- 
*/ 

#ifndef OS_GLOB_H
#define OS_GLOB_H

/*==== INCLUDES =============================================================*/

#include "os_types.h"

/*==== CONSTANTS ============================================================*/

/*==== TYPES ================================================================*/

/*==== VARIABLES ============================================================*/
 
#ifndef CONFIG_MODULE

extern USHORT MaxTasks;
extern USHORT MaxCommunications;
extern USHORT MaxSimultaneousTimer;
extern USHORT MaxTimer;
extern USHORT MaxSemaphores;
extern USHORT MaxOSISRs;
extern USHORT MaxEventGroups;
extern USHORT MaxPoolGroups;
extern USHORT MaxMemoryPools;
#else

#ifndef DATA_INT_RAM
USHORT MaxOSISRs = MAX_OSISRS;
USHORT MaxTasks = MAX_OS_TASKS;
USHORT MaxCommunications = MAX_COMMUNICATIONS;
USHORT MaxSimultaneousTimer = MAX_SIMULTANEOUS_TIMER;
USHORT MaxSemaphores = MAX_SEMAPHORES;
USHORT MaxEventGroups = MAX_EVENT_GROUPS;
USHORT MaxPoolGroups = MAX_POOL_GROUPS;
USHORT MaxMemoryPools = MAX_MEMORY_POOLS;

GLOBAL T_OS_TASK_TABLE_ENTRY TaskTable    [ MAX_OS_TASKS + 1 ];
GLOBAL T_OS_COM_TABLE_ENTRY ComTable      [ MAX_COMMUNICATIONS + 1 ];
GLOBAL T_OS_TIMER_ENTRY TimerTable        [ MAX_SIMULTANEOUS_TIMER + 1 ];
GLOBAL T_OS_SEM_TABLE_ENTRY SemTable      [ MAX_SEMAPHORES + 1 ];
GLOBAL T_OS_OSISR_TABLE_ENTRY OSISRTable  [ MAX_OSISRS + 1 ];
GLOBAL T_OS_PART_GRP_TABLE_ENTRY PartGrpTable  [ MAX_POOL_GROUPS + 1 ];
GLOBAL T_OS_MEM_POOL_TABLE_ENTRY MemPoolTable  [ MAX_MEMORY_POOLS + 1 ];
GLOBAL T_OS_EVTGRP_TABLE_ENTRY EvtGrpTable[ MAX_EVENT_GROUPS + 1 ];
GLOBAL T_OS_TIMER_TABLE_ENTRY *p_list     [ MAX_SIMULTANEOUS_TIMER + 1 ];
GLOBAL T_OS_POOL_BORDER PoolBorder        [ MAX_POOL_GROUPS+1];

GLOBAL const char *os_dar_filename = "/var/dbg/dar";
GLOBAL ULONG os_dar_write_buffer_size = 3000;
#endif /* DATA_INT_RAM */


#endif

#endif