view src/gpf2/inc/stddefs.h @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 864b8cc0cf63
children
line wrap: on
line source

/* 
+------------------------------------------------------------------------------
|  File:       stddefs.h
+------------------------------------------------------------------------------
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Old frame standard definitions.
+----------------------------------------------------------------------------- 
*/ 


#ifndef __STDDEFS_H__
#define __STDDEFS_H__

#ifndef OLD_FRAME
 #ifndef NEW_FRAME
  #define NEW_FRAME
 #endif
#endif

/*==== CONSTANTS ==================================================*/

#define FALSE  0
#define TRUE   1

#define BIT123  0x07
#define BIT4    0x08
#define BIT78   0xC0

#if defined (USE_DLL)
  #ifdef WIN32
    #define EXPORT __declspec (dllexport)
    #define IMPORT __declspec (dllimport)
  #endif
#else
  #define EXPORT GLOBAL
  #define IMPORT EXTERN
#endif

#ifndef __cplusplus
  #define EXTERN extern 
#else 
  #define EXTERN extern "C"
#endif

/* Horrible handling of GLOBAL and MAINFILE macros
   Documented in BugTrak#DNCL-3PWCL3 */
#ifdef L1_LIB
  #ifdef L1_COM_C
    #define GLOBAL 
    #define MAINFILE 1
  #else
    #ifndef __cplusplus   
      #define GLOBAL extern 
    #else 
      #define GLOBAL extern "C"
    #endif
  #endif
#else
  #define GLOBAL
#endif

#define LOCAL   static

#define AND &&
#define OR  ||
#define XOR(A,B) ((!(A) AND (B)) OR ((A) AND !(B)))

#define EQ  ==
#define NEQ !=

#ifndef NULL
#define NULL    0
#endif
/*==== TYPES ======================================================*/
#ifndef WIN32
  typedef char           BYTE;
#else
  typedef unsigned char  BYTE;
#endif

#if !defined (NUCLEUS)
typedef char           CHAR;
#endif



typedef long           LONG;
typedef unsigned char  UBYTE;
typedef unsigned char  UCHAR;
typedef unsigned short USHORT;
typedef unsigned long  ULONG;
typedef unsigned short UINT16;
typedef unsigned long  UINT32;
typedef unsigned short UNSIGNED16;

typedef unsigned long T_VOID_STRUCT;

#ifndef L1_LIB
typedef short          SHORT;
#ifdef WIN32
  typedef int            BOOL;
#else
  typedef UBYTE          BOOL;
#endif
#endif

#if !defined (T_SDU_DEFINED)

#define T_SDU_DEFINED

typedef struct
{
  USHORT l_buf;
  USHORT o_buf;
  UBYTE  buf[1];
} T_sdu;

#endif /* T_SDU_DEFINED */


#if !defined (T_FRAME_DESC_DEFINED)

#define T_FRAME_DESC_DEFINED

typedef struct 
{
  UBYTE  *Adr[2];
  USHORT  Len[2];
} T_FRAME_DESC;

#endif /* T_FRAME_DESC_DEFINED */


/*
 * for definitions of jumptables
 */
#ifndef NEW_ENTITY
 typedef void   (*T_VOID_FUNC)();
 typedef short  (*T_SHORT_FUNC)();
#endif
typedef USHORT (*T_USHORT_FUNC)();

/* SDU_TRAIL denotes the memory size starting at 'buf' to the end of T_sdu */

#define  SDU_TRAIL  ((char*)(((T_sdu*)0)+1)-(char*)(((T_sdu*)0)->buf))

/*==== EXPORT =====================================================*/
#define MAXIMUM(A,B) (((A)>(B))?(A):(B))

#define MINIMUM(A,B) (((A)<(B))?(A):(B))

#define _STR(x)  __STR(x)
#define __STR(x) #x

#define ALERT(CONDITION,TEXT) \
        {														   \
		   if (!(CONDITION))									   \
		      ext_abort (#TEXT "\n" __FILE__ ", line " _STR(__LINE__)); \
		}


/*==== MISC =======================================================*/


#endif