view src/gpf2/misc/trace.c @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents cd37d228dae0
children
line wrap: on
line source

/* 
+------------------------------------------------------------------------------
|  File:       trace.c
+------------------------------------------------------------------------------
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  This Modul provides data and functions for fast in memory tracing
+----------------------------------------------------------------------------- 
*/ 

#ifndef TRACE_C
#define TRACE_C
#endif
#define FAST_TRACE

/*==== INCLUDES ===================================================*/

#include <string.h>
#include "typedefs.h"
#include "header.h"
#include "custom.h"
#include "vsi.h"
#include "gsm.h"
#include "prim.h"
#include "pei.h"
#include "tok.h"

#include "trace.h"

#include <string.h>
#include <stdio.h>
#include "message.h"

/*==== CONST ======================================================*/

#define TRC_ENTITY 0x60
#define TRC_FILE   1


#ifdef OPTION_MULTITHREAD
#define VSI_CALLER "ACI",
#define VSI_CALLER_SINGLE "ACI"
#else
#define VSI_CALLER
#define VSI_CALLER_SINGLE
#endif


/*==== TYPES ======================================================*/

/*==== VARIABLES ==================================================*/


/*==== FUNCTIONS ==================================================*/
/*
+--------------------------------------------------------------------+
| PROJECT : GSM-F&D (8411)        MODULE  : TRACE                    |
| STATE   : code                  ROUTINE : trc_init                 |
+--------------------------------------------------------------------+

  PURPOSE : This function is called to initialize the trace function

*/

GLOBAL void trc_init
            (
              void
            )
{
  trc_p_buffer     = trc_buffer;
  trc_p_buffer_end = &trc_buffer[TRC_BUF_LEN-1];
  trc_wrap_around  = FALSE;
  trc_wrap_around_enable  = TRUE;
  trc_enabled      = TRUE;
  /*semTRC = vsi_s_open (VSI_CALLER "TRC"); */
}


/*
+--------------------------------------------------------------------+
| PROJECT : GSM-F&D (8411)        MODULE  : TRACE                    |
| STATE   : code                  ROUTINE : trc_enable_wrap_around   |
+--------------------------------------------------------------------+

  PURPOSE : This function is called to enable wrap around

*/

GLOBAL void trc_enable_wrap_around
            (
              void
            )
{
  trc_wrap_around_enable = TRUE;
}


/*
+--------------------------------------------------------------------+
| PROJECT : GSM-F&D (8411)        MODULE  : TRACE                    |
| STATE   : code                  ROUTINE : trc_disable_wrap_around  |
+--------------------------------------------------------------------+

  PURPOSE : This function is called to disable wrap around

*/

GLOBAL void trc_disable_wrap_around
            (
              void
            )
{
  trc_wrap_around_enable  = FALSE;
}


/*
+--------------------------------------------------------------------+
| PROJECT : GSM-F&D (8411)        MODULE  : TRACE                    |
| STATE   : code                  ROUTINE : trc_enable               |
+--------------------------------------------------------------------+

  PURPOSE : This function is called to enable fast trace

*/

GLOBAL void trc_enable
            (
              void
            )
{
  trc_enabled = TRUE;
}


/*
+--------------------------------------------------------------------+
| PROJECT : GSM-F&D (8411)        MODULE  : TRACE                    |
| STATE   : code                  ROUTINE : trc_disable              |
+--------------------------------------------------------------------+

  PURPOSE : This function is called to disable fast trace

*/

GLOBAL void trc_disable
            (
              void
            )
{
  trc_enabled  = FALSE;
}


/*
+--------------------------------------------------------------------+
| PROJECT : GSM-F&D (8411)        MODULE  : RA_SHM                   |
| STATE   : code                  ROUTINE : trc_dump                 |
+--------------------------------------------------------------------+

  PURPOSE : the content of the stored dump is dumped 
            into the system trace window.
  
*/

GLOBAL void trc_dump (void)
{
  T_TRC_BUF_ENTRY *p_readOut;
  ULONG *p;
  ULONG i;
  char buf [40];
  char buf1 [40];

#ifndef NEW_FRAME
  vsi_o_trace ("", 0xff, "---FASTTRACEBUFFER---");
#else
  vsi_o_ttrace (0, 0xff, "---FASTTRACEBUFFER---");
#endif
  if (trc_wrap_around)
  {
    for (p_readOut= trc_p_buffer;
         p_readOut < trc_p_buffer_end;
         p_readOut++)
    {
      p = (ULONG*)p_readOut;

      buf1[0]='\0';

      for (i = sizeof(T_TRC_BUF_ENTRY); i>=0; i-=sizeof(ULONG))
      {
        sprintf(buf1, "0x%x ", *p++);
        strcat (buf, buf1);
      }
#ifndef NEW_FRAME
      vsi_o_trace ("", 0xff, buf);
      vsi_t_sleep("", 1);
#else
      vsi_o_ttrace (0, 0xff, buf);
      vsi_t_sleep(0, 1);
#endif
    }
  }
  for (p_readOut= trc_buffer;
       p_readOut < trc_p_buffer;
       p_readOut++)
  {
    p = (ULONG*)p_readOut;

    buf1[0]='\0';

    for (i = sizeof(T_TRC_BUF_ENTRY); i>=0; i-=sizeof(ULONG))
    {
      sprintf(buf1, "0x%x ", *p++);
      strcat (buf, buf1);
    }
#ifndef NEW_FRAME
    vsi_o_trace ("", 0xff, buf);
    vsi_t_sleep("", 1);
#else
    vsi_o_ttrace (0, 0xff, buf);
    vsi_t_sleep(0, 1);
#endif
  }

#ifndef NEW_FRAME
  vsi_o_trace ("", 0xff, "---END---");
#else
  vsi_o_ttrace (0, 0xff, "---END---");
#endif
}