FreeCalypso > hg > fc-magnetite
view src/gpf2/osl/os_pro_ir.c @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | dfa8771e84b1 |
children |
line wrap: on
line source
/* * This C module is a reconstruction based on the disassembly of * os_pro.obj in frame_na7_db_ir.lib from the Leonardo package. */ /* set of included headers from COFF symtab: */ #include <stdio.h> #include <string.h> #include "nucleus.h" #include "typedefs.h" #include "os.h" #include "gdi.h" #include "os_types.h" #include "os_glob.h" extern VOID *TCD_Current_Thread; extern T_OS_TASK_TABLE_ENTRY TaskTable[]; extern unsigned os_time_to_tick_multiplier; #define OS_NU_TASK_MAGIC 0xdeafbeef VOID os_TaskEntry(UNSIGNED TaskHandle, VOID *argv) { TaskTable[TaskHandle].TaskEntry(TaskHandle, 0); } GLOBAL LONG os_SuspendTask(OS_HANDLE Caller, ULONG Time) { UNSIGNED SuspendTicks; SuspendTicks = TIME_TO_SYSTEM_TICKS(Time); if (!SuspendTicks) SuspendTicks = 1; NU_Sleep(SuspendTicks); return (OS_OK); } GLOBAL LONG os_ResumeTask(OS_HANDLE task_handle) { if (NU_Resume_Task(&TaskTable[task_handle].TaskCB.TCB) == NU_SUCCESS) return(OS_OK); else return(OS_ERROR); } GLOBAL LONG os_Relinquish(void) { NU_Relinquish(); return(OS_OK); } GLOBAL OS_HANDLE os_MyHandle(void) { OS_NU_TASK *os_nu_task = (OS_NU_TASK *) TCD_Current_Thread; if (os_nu_task && os_nu_task->magic_nr == OS_NU_TASK_MAGIC) return(os_nu_task->handle); else return(OS_NOTASK); } GLOBAL LONG os_GetTaskName(OS_HANDLE Caller, OS_HANDLE TaskHandle, char *Name) { if (TaskHandle) { if (TaskHandle > MaxTasks || !TaskTable[TaskHandle].Name[0]) return(OS_ERROR); strcpy(Name, TaskTable[TaskHandle].Name); } else if (TCD_Current_Thread) { NU_TASK *curtask = TCD_Current_Thread; strcpy(Name, curtask->tc_name); } else strcpy(Name, "ROOT"); return(OS_OK); } GLOBAL LONG os_DeferTask(OS_HANDLE task_handle, OS_TIME time) { if (NU_Suspend_Task(&TaskTable[task_handle].TaskCB.TCB) == NU_SUCCESS) return(OS_OK); else return(OS_ERROR); } GLOBAL LONG os_CheckTaskStack(OS_HANDLE Handle) { #ifdef __GNUC__ register void *sp asm("sp"); #endif if (*TaskTable[Handle].Stack != GUARD_PATTERN) return(OS_ERROR); #ifdef __GNUC__ if (TCD_Current_Thread) { NU_TASK *curtask = TCD_Current_Thread; if (sp < curtask->tc_stack_start) return(OS_ERROR); } #endif return(OS_OK); }