FreeCalypso > hg > fc-magnetite

view src/gpf3/ccd/bitfun.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c41a534f33c6
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  
|  Modul   : bitfun.h
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Condat Coder Decoder
|             Prototypes of the elementary bit manipulation functions
+----------------------------------------------------------------------------- 
*/ 


#ifndef __BITFUN
#define __BITFUN


#ifndef __BITFUN_C__

EXTERN void   bf_writePadBits      (T_CCD_Globs *globs);
EXTERN void   bf_writeVal          (ULONG value, ULONG bSize, T_CCD_Globs *globs);
EXTERN ULONG  bf_getBits           (ULONG  len, T_CCD_Globs *globs);
EXTERN void   bf_writeBitStr_PER   (USHORT len, T_CCD_Globs *globs);
EXTERN void   bf_readBitStr_PER    (USHORT len, T_CCD_Globs *globs);
EXTERN void   bf_writeBits         (ULONG  len, T_CCD_Globs *globs);
EXTERN void   bf_readBits          (ULONG  len, T_CCD_Globs *globs);
EXTERN void   bf_writeBitChunk     (ULONG  len, T_CCD_Globs *globs);
EXTERN void   bf_readBitChunk      (ULONG  len, T_CCD_Globs *globs);
EXTERN BOOL   bf_readBit           (T_CCD_Globs *globs);
EXTERN void   bf_writeBit          (BOOL Bit, T_CCD_Globs *globs);
EXTERN UBYTE  bf_decodeByteNumber  (const ULONG len, T_CCD_Globs *globs);
EXTERN ULONG  bf_decodeShortNumber (const ULONG len, T_CCD_Globs *globs);
EXTERN ULONG  bf_decodeLongNumber  (UBYTE len, T_CCD_Globs *globs);
EXTERN void   bf_codeShortNumber   (UBYTE len, USHORT val, T_CCD_Globs *globs);
EXTERN void   bf_codeByteNumber    (UBYTE len, UBYTE val, T_CCD_Globs *globs);
EXTERN void   bf_codeLongNumber    (UBYTE len, ULONG val, T_CCD_Globs *globs);
EXTERN void   bf_recodeShortNumber (USHORT pos, UBYTE len, USHORT val, T_CCD_Globs *globs);
EXTERN void   bf_recodeByteNumber  (USHORT pos, UBYTE len, UBYTE  val, T_CCD_Globs *globs);
EXTERN void   bf_recodeBit         (USHORT pos, UBYTE Bit, T_CCD_Globs *globs);
EXTERN void   bf_rShift8Bit        (USHORT srcBitPos, USHORT bitLen, T_CCD_Globs *globs);

#endif /* __BITFUN_C__ */

/* a Macro for incrementing the position in the bitbuffer         */
/* _bitpos, _bytepos and _byteoffs are recalculated               */

#define bf_incBitpos(A, globs) globs->bitpos = (USHORT)(globs->bitpos+(A));\
                        globs->bytepos = (USHORT)(globs->bitpos >> 3);\
                        globs->byteoffs = (UBYTE)(globs->bitpos & 7)
#define bf_setBitpos(A, globs) globs->bitpos = (USHORT)(A);\
                        globs->bytepos = (USHORT)(globs->bitpos >> 3);\
                        globs->byteoffs = (UBYTE)(globs->bitpos & 7)

/*
 * end of bitstream if we can not read almost 4 bits
 */
#define bf_endOfBitstream(globs) (globs->bitpos >= globs->maxBitpos)

#endif