FreeCalypso > hg > fc-magnetite

view src/gpf3/ccd/ccddata_version.c @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c41a534f33c6
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  
|  Modul   :  ccddata_version.c
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  This files supplies function delivering version information
|             about ccddata and the tables.
+----------------------------------------------------------------------------- 
*/ 

/*==== INCLUDES =============================================================*/
static char*
#include "ccddata_version.h"
;

#include "typedefs.h"
#include "ccdtable.h"

/*==== CONSTS ================================================================*//*==== TYPES =================================================================*/
/*==== LOCALS ================================================================*/
/*==== PRIVATE FUNCTIONS =====================================================*/
/*==== PUBLIC FUNCTIONS ======================================================*/

/*
+------------------------------------------------------------------------------
|  Function     :  ccddata_get_version
+------------------------------------------------------------------------------
|  Description  :  Deliver the version of ccddata. In ccddata_version.h the
|                  variable CCDDATA_VERSION defines a string containing the
|                  version information. This file may only contain one line
|                  CCDDATA_VERSION="X.Y.Z"
|                  because it is also used by ccddata.mk.
|
|  Parameters   :  none
|
|  Return       :  The string containing the version information.
+------------------------------------------------------------------------------
*/

char* ccddata_get_version ()
{
  return CCDDATA_VERSION;
}

/*
+------------------------------------------------------------------------------
|  Function     :  ccddata_get_table_version
+------------------------------------------------------------------------------
|  Description  :  Deliver the version of ccddata tables.
|                  The version is a constant from ccdtable.h and is increased
|                  if the tables format changes.
|
|  Parameters   :  none
|
|  Return       :  The version number.
+------------------------------------------------------------------------------
*/

int ccddata_get_table_version ()
{
  return CCDDATA_TABLE_VERSION;
}