FreeCalypso > hg > fc-magnetite

view src/gpf3/ccd/csn1_s1_opt.c @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c41a534f33c6
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  
|  Modul   : csn1_s1_opt.c
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definition of encoding and decoding functions for CSN1_S1 elements 
+----------------------------------------------------------------------------- 
*/ 


/*
 * standard definitions like GLOBAL, UCHAR, ERROR etc.
 */
#include "typedefs.h"
#include "header.h"

/*
 * Prototypes of ccd (USE_DRIVER EQ undef) for prototypes only
 * look at ccdapi.h
 */
#undef USE_DRIVER
#include "ccdapi.h"

/*
 * Types and functions for bit access and manipulation
 */
#include "ccd_globs.h"
#include "bitfun.h"

/*
 * Prototypes of ccd internal functions
 */
#include "ccd.h"

/*
 * Declaration of coder/decoder tables
 */
#include "ccdtable.h"
#include "ccddata.h"

extern SHORT cdc_csn1_sx_decode (int flag, const ULONG e_ref, T_CCD_Globs *globs);
extern SHORT cdc_csn1_sx_encode (int flag, const ULONG e_ref, T_CCD_Globs *globs);

#ifndef RUN_FLASH
/*
+------------------------------------------------------------------------+
| PROJECT : CCD (6144)               MODULE  : CDC_GSM                   |
| STATE   : code                     ROUTINE : cdc_csn1_s1_opt_decode    |
+------------------------------------------------------------------------+

  PURPOSE : Decoding of the GSM Type CSN1 S1 element. This element
            consists of a 1 bit valid flag and a value part.
            Only if the valid bit is equal 1 the value part follows.

            The element value can be present, then it is preceded by the 
            flag value 0. If the element is represented by the flag 1 only 
            the value is absent! Besides the absence of the whole element 
            is allowed.
*/

SHORT cdc_csn1_s1_opt_decode (const ULONG c_ref, const ULONG e_ref, T_CCD_Globs *globs)
{
#ifdef DEBUG_CCD
  #ifndef CCD_SYMBOLS
  TRACE_CCD (globs, "cdc_csn1_s1_opt_decode()");
	#else
	TRACE_CCD (globs, "cdc_csn1_s1_opt_decode() %s", ccddata_get_alias((USHORT) e_ref, 1));
	#endif
#endif

  return cdc_csn1_sx_decode (1, e_ref, globs);
}
#endif /* !RUN_FLASH */

#ifndef RUN_FLASH
/*
+------------------------------------------------------------------------+
| PROJECT : CCD (6144)              MODULE  : CDC_GSM                    |
| STATE   : code                    ROUTINE : cdc_csn1_s1_opt_encode     |
+------------------------------------------------------------------------+

  PURPOSE : Encoding of the GSM Type CSN1 S1 element. This element
            consists of a 1 bit valid flag and a value part. If the
            element is valid (the v_xxx components is TRUE in the 
            decoded message) a 1 bit will be coded followed by the
            coding of the value part. Otherwise a 0 bit will be 
            coded.

*/

SHORT cdc_csn1_s1_opt_encode (const ULONG c_ref, const ULONG e_ref, T_CCD_Globs *globs)
{
#ifdef DEBUG_CCD
  #ifndef CCD_SYMBOLS
  TRACE_CCD (globs, "cdc_csn1_s1_opt_encode()");
	#else
	TRACE_CCD (globs, "cdc_csn1_s1_opt_encode() %s", ccddata_get_alias((USHORT) e_ref, 1));
	#endif
#endif

  return cdc_csn1_sx_encode (1, e_ref, globs);
}
#endif /* !RUN_FLASH */