FreeCalypso > hg > fc-magnetite

view src/gpf3/ccd/mall @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c41a534f33c6
children
line wrap: on
line source

#!/bin/sh

help ()
{
  echo "Usage: $0 { -help|-gmake|-l <LABEL>|-clean|-exp|-unco}"
  exit 0
}

error ()
{
  grep "error " $err_file
  echo "Errors occurred! See $err_file for details."
  exit 1
}

if [ "$WINWORD" != "" ] ; then
# Windows environment
  OSENV=windows
  if [ "$CLEARCASE_PRIMARY_GROUP" == "" ] ; then
    HAVE_CC=0
  else
    cleartool lsview -cview >nul 2>&1
    if [ $? == 0 ] ; then
      HAVE_CC=1
    else
      HAVE_CC=0
    fi
  fi
else
  OSENV=`uname`
  cleartool lsview -cview >/dev/null 2>&1
  if [ $? == 0 ] ; then
    HAVE_CC=1
  else
    HAVE_CC=0
  fi
fi

if [ $HAVE_CC == 1 ] ; then
  M="clearmake -V -C gnu"
else
  if [ $OSENV == windows ] ; then
    M="gnumake -r"
  else
    M="make -r"
  fi
fi

name=CCD
name_small=ccd
err_file=../$name_small.err
ver=0
maketarget="colibs all"

if [ "$1" != "" ] ; then 

  case "$1" in
    -clean)
       maketarget=clean
       ;;
    -gmake)
       if [ $OSENV == windows ] ; then
         M="gnumake -r"
       else
         M="make -r"
       fi
       ;;
    -test)
       echo testing not yet implemented
       exit 0
       ;;
    -exp)
       maketarget="colibs all cilibs"
       ;;
    -l)
       echo labelling not yet implemented
       exit 0
       ;;
    -help)
       help
       ;;
    *) 
       echo Unknown option "$1"
       help
       ;;
  esac

fi

rm -f $err_file

if [ "$maketarget" == clean ] ; then
  echo "*** cleaning $name ***" | tee -a $err_file
elif [ "$maketarget" == "colibs all cilibs" ] ; then
  echo "*** making and checking in $name ***" | tee -a $err_file
else
  echo "*** making $name ***" | tee -a $err_file
fi

case "$OSENV" in
  windows)
	   echo "Use mall.bat to build under windows environments." >> $err_file
		 error
     ;;

  Linux)
     echo $M $maketarget TARGET=linuxpc DEBUG=0 TRACE=0 MEMSUPER=0 >> $err_file
     $M $maketarget TARGET=linuxpc DEBUG=0 TRACE=0 MEMSUPER=0 >> $err_file 2>&1
     if [ $? != 0 ] ; then error ; fi
     echo $M $maketarget TARGET=linuxpc DEBUG=1 TRACE=0 MEMSUPER=0 >> $err_file
     $M $maketarget TARGET=linuxpc DEBUG=1 TRACE=0 MEMSUPER=0 >> $err_file 2>&1
     if [ $? != 0 ] ; then error ; fi
     echo $M $maketarget TARGET=linuxpc DEBUG=1 TRACE=1 MEMSUPER=0 >> $err_file
     $M $maketarget TARGET=linuxpc DEBUG=1 TRACE=1 MEMSUPER=0 >> $err_file 2>&1
     if [ $? != 0 ] ; then error ; fi
     echo $M $maketarget TARGET=linuxarm DEBUG=0 TRACE=0 MEMSUPER=0 >> $err_file
     $M $maketarget TARGET=linuxarm DEBUG=0 TRACE=0 MEMSUPER=0 >> $err_file 2>&1
     if [ $? != 0 ] ; then error ; fi
     echo $M $maketarget TARGET=linuxarm DEBUG=1 TRACE=0 MEMSUPER=0 >> $err_file
     $M $maketarget TARGET=linuxarm DEBUG=1 TRACE=0 MEMSUPER=0 >> $err_file 2>&1
     if [ $? != 0 ] ; then error ; fi
     echo $M $maketarget TARGET=linuxarm DEBUG=1 TRACE=1 MEMSUPER=0 >> $err_file
     $M $maketarget TARGET=linuxarm DEBUG=1 TRACE=1 MEMSUPER=0 >> $err_file 2>&1
     if [ $? != 0 ] ; then error ; fi
     ;;
  Solaris)
     echo $M $maketarget TARGET=solsparc DEBUG=0 TRACE=0 MEMSUPER=0 >> $err_file
     $M $maketarget TARGET=solsparc DEBUG=0 TRACE=0 MEMSUPER=0 >> $err_file 2>&1
     if [ $? != 0 ] ; then error ; fi
     echo $M $maketarget TARGET=solsparc DEBUG=1 TRACE=0 MEMSUPER=0 >> $err_file
     $M $maketarget TARGET=solsparc DEBUG=1 TRACE=0 MEMSUPER=0 >> $err_file 2>&1
     if [ $? != 0 ] ; then error ; fi
     echo $M $maketarget TARGET=solsparc DEBUG=1 TRACE=1 MEMSUPER=0 >> $err_file
     $M $maketarget TARGET=solsparc DEBUG=1 TRACE=1 MEMSUPER=0 >> $err_file 2>&1
     if [ $? != 0 ] ; then error ; fi
     ;;
esac

exit 0