FreeCalypso > hg > fc-magnetite
view src/gpf3/inc/nuc/sm_defs.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | c41a534f33c6 |
children |
line wrap: on
line source
/*************************************************************************/ /* */ /* Copyright (c) 1993-1996 Accelerated Technology, Inc. */ /* */ /* PROPRIETARY RIGHTS of Accelerated Technology are involved in the */ /* subject matter of this material. All manufacturing, reproduction, */ /* use, and sales rights pertaining to this subject matter are governed */ /* by the license agreement. The recipient of this software implicitly */ /* accepts the terms of the license. */ /* */ /*************************************************************************/ /*************************************************************************/ /* */ /* FILE NAME VERSION */ /* */ /* sm_defs.h PLUS 1.2 */ /* */ /* COMPONENT */ /* */ /* SM - Semaphore Management */ /* */ /* DESCRIPTION */ /* */ /* This file contains data structure definitions and constants for */ /* the Semaphore component. */ /* */ /* AUTHOR */ /* */ /* William E. Lamie, Accelerated Technology, Inc. */ /* */ /* DATA STRUCTURES */ /* */ /* SM_SCB Semaphore control block */ /* SM_SUSPEND Semaphore suspension block */ /* */ /* FUNCTIONS */ /* */ /* None */ /* */ /* DEPENDENCIES */ /* */ /* cs_defs.h Common service definitions */ /* tc_defs.h Thread Control definitions */ /* */ /* HISTORY */ /* */ /* NAME DATE REMARKS */ /* */ /* W. Lamie 03-01-1993 Created initial version 1.0 */ /* D. Lamie 04-19-1993 Verified version 1.0 */ /* W. Lamie 03-01-1994 Moved include files outside of */ /* the file #ifndef to allow the */ /* use of actual data structures, */ /* removed protection structure, */ /* put padding into structure, */ /* resulting in version 1.1 */ /* R. Pfaff - */ /* D. Lamie 03-18-1994 Verified version 1.1 */ /* M.Q. Qian 04-17-1996 updated to version 1.2 */ /* */ /*************************************************************************/ #include "cs_defs.h" /* Common service constants */ #include "tc_defs.h" /* Thread control constants */ /* Check to see if the file has been included already. */ #ifndef SM_DEFS #define SM_DEFS /* Define constants local to this component. */ #define SM_SEMAPHORE_ID 0x53454d41UL /* Define the Semaphore Control Block data type. */ typedef struct SM_SCB_STRUCT { CS_NODE sm_created; /* Node for linking to */ /* created semaphore list */ UNSIGNED sm_id; /* Internal SCB ID */ CHAR sm_name[NU_MAX_NAME]; /* Semaphore name */ UNSIGNED sm_semaphore_count; /* Counting semaphore */ DATA_ELEMENT sm_fifo_suspend; /* Suspension type flag */ #if PAD_1 DATA_ELEMENT sm_padding[PAD_1]; #endif UNSIGNED sm_tasks_waiting; /* Number of waiting tasks*/ struct SM_SUSPEND_STRUCT *sm_suspension_list; /* Suspension list */ } SM_SCB; /* Define the semaphore suspension structure. This structure is allocated off of the caller's stack. */ typedef struct SM_SUSPEND_STRUCT { CS_NODE sm_suspend_link; /* Link to suspend blocks */ SM_SCB *sm_semaphore; /* Pointer to semaphore */ TC_TCB *sm_suspended_task; /* Task suspended */ STATUS sm_return_status; /* Return status */ } SM_SUSPEND; #endif