view src/gpf3/inc/p_frame.h @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c41a534f33c6
children
line wrap: on
line source

/* 
+------------------------------------------------------------------------------
|  File:       frm_primitives.h
+------------------------------------------------------------------------------
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions for frame primitives.
+----------------------------------------------------------------------------- 
*/ 

#ifndef FRM_PRIMITIVES_H
#define FRM_PRIMITIVES_H

#define FRM_ERROR_IND     0xC000001E  /* SAP NR: 30 (0x1e), PRIM NR 0 */
#define FRM_WARNING_IND   0xC001001E  /* SAP NR: 30 (0x1e), PRIM NR 1 */

/* maximum length of a string in frame primitives */
#define FRM_PRIM_STR_SIZE   100

/* spontaneuous frame output */
typedef struct
{
  U32   error_code;
  char  error_string [ FRM_PRIM_STR_SIZE ];
} T_FRM_ERROR_IND;

typedef struct
{
  U32   warning_code;
  char  warning_string [ FRM_PRIM_STR_SIZE ];
} T_FRM_WARNING_IND;

#if 0
/* frame status requests and confirmations */

/* register destination for error/warning indications */

typedef struct
{
  char  name [ RESOURCE_NAMELEN ];
} T_FRM_REGISTER_REQ;

typedef struct
{
  char  name [ RESOURCE_NAMELEN ];
} T_FRM_REGISTER_CNF;

/* task status */

typedef struct
{
  U32   task_id;
} T_FRM_TASK_STATUS_REQ;

typedef struct
{
  char  name [ RESOURCE_NAMELEN ];
  U32   priority;
  U32   stacksize;
  U32   unused_stack;
} T_FRM_TASK_DATA;

typedef struct
{
  T_FRM_TASK_DATA   task [ MAX_OS_TASKS ];;
} T_FRM_TASK_STATUS_CNF;

/* partition status */

typedef struct
{
  U32   partition_group_id;
} T_FRM_PARTITION_STATUS_REQ;

typedef struct
{
  T_FRM_PARTITION_DATA p_pool [ MAX_POOL_GROUPS*MAX_POOLS_PER_GROUP ];
} T_FRM_PARTITION_STATUS_CNF;

typedef struct
{
  U32   partition_pool_id;
  U32   partition_size
  U32   available;
  U32   allocated;
} T_FRM_PARTITION_DATA;

/* memory status */
typedef struct
{
  U32   memory_pool_id;
} T_FRM_MEMORY_STATUS_REQ;

typedef struct
{
  U32   memory_pool_id;
  U32   pool_size
  U32   available;
  U32   allocated;
} T_FRM_MEMORY_DATA;

typedef struct
{
  T_FRM_MEMORY_DATA m_pool [ MAX_MEMORY_POOLS };
} T_FRM_MEMORY_STATUS_CNF;

/* timer status */

typedef struct
{
  U32   timer_id;
} T_FRM_TIMER_STATUS_REQ;

typedef struct
{
  U32   max_timer;
  U32   max_simul_available_timer;
  U32   max_simul_running_timer;
} T_FRM_TIMER_STATUS_CNF;

/* semaphore status */

typedef struct
{
  U32   semaphore_id;
} T_FRM_SEMAPHORE_STATUS_REQ;

typedef struct
{
} T_FRM_SEMAPHORE_STATUS_CNF;
#endif

#endif /* FRM_PRIMITIVES_H */