FreeCalypso > hg > fc-magnetite
view src/gpf3/inc/pei.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | c41a534f33c6 |
children |
line wrap: on
line source
/* +------------------------------------------------------------------------------ | File: pei.h +------------------------------------------------------------------------------ | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : Protocol Entity Interface exported definitions. +----------------------------------------------------------------------------- */ #ifndef __PEI_H__ #define __PEI_H__ /*==== INCLUDES ============================================================*/ #include <stddef.h> /*==== CONSTANTS ===========================================================*/ #define PEI_OK 0 #define PEI_ERROR (-1) /*==== TYPES ===============================================================*/ typedef int T_PEI_RETURN; typedef char * T_PEI_CONFIG; typedef void T_PEI_MONITOR; /* * types and macros for pei-jumptable processing */ #define PALLOC_TRANSITION /* to reinsert the sdu pointer in pei_primitive */ #define NO_COPY_ROUTING /* has to be set for frame version > 2.5.0 */ /* * for definitions of jumptables */ typedef void (*T_VOID_FUNC)(); typedef short (*T_SHORT_FUNC)(); typedef struct { T_VOID_FUNC func; size_t size; size_t soff; ULONG opc; } T_FUNC; #define MAK_FUNC_S(FUNC,OPC) { (T_VOID_FUNC)FUNC, sizeof(T_##OPC), offsetof(T_##OPC,sdu), OPC } #define MAK_FUNC_0(FUNC,OPC) { (T_VOID_FUNC)FUNC, sizeof(T_##OPC), 0 , OPC } #define MAK_FUNC_N(FUNC,OPC) { (T_VOID_FUNC)FUNC, 0 , 0 , 0 } #define TAB_SIZE(T) (sizeof T / sizeof *T) typedef struct { SHORT (*pei_init)(T_HANDLE); SHORT (*pei_exit)(void); SHORT (*pei_primitive)(void*); SHORT (*pei_timeout)(USHORT); SHORT (*pei_signal)(ULONG,void*); SHORT (*pei_run)(T_HANDLE,T_HANDLE); SHORT (*pei_config)(char*); SHORT (*pei_monitor)(void**); } T_PEI_FUNC; typedef struct { char const *Name; T_PEI_FUNC PeiTable; ULONG StackSize; USHORT QueueEntries; USHORT Priority; USHORT NumOfTimers; U32 Flags; } T_PEI_INFO; #endif /* __PEI_H__ */