FreeCalypso > hg > fc-magnetite
view src/ui3/atb/ATBPbFS.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | e8ddbb0837ed |
| children |
line wrap: on
line source
/********************************************* * PB_RECS_PER_FILE * * Specifies how many records should be stored in * each file on the flash. *********************************************/ #define PB_RECS_PER_FILE 10 /********************************************* * PB_xxx_UPPER_LIMIT * * The absolute maximum size of various aspects * of the records stored on the file system. Used * to keep values read in from file within a * sensible range. *********************************************/ #define PB_RECORDS_UPPER_LIMIT 500 #define PB_ALPHATAG_UPPER_LIMIT 500 #define PB_NUMBER_UPPER_LIMIT 500 #define PB_EXT_UPPER_LIMIT 500 /********************************************** * T_PB_FSDATA * * Internal information for FS *********************************************/ typedef struct { SHORT records_max; SHORT alpha_max; SHORT number_max; SHORT ext_max; SHORT record_size; T_FFS_FD info_file; SHORT fileID; T_FFS_FD file; } T_PB_FSDATA; /********************************************** * T_PB_FSINFO * * Information about phonebook - * e.g. is SIM or FFS selected ? *********************************************/ typedef struct { UBYTE type_selected; /* The current selected phonebook */ SHORT records_max; SHORT alpha_max; SHORT number_max; SHORT ext_max; } T_PB_FSINFO; /********************************************** * LOCAL FUNCTION PROTOTYPES * *********************************************/ void FS_file_GetIndex(SHORT phys_index, SHORT *fileIndex, SHORT *recIndex); void FS_file_GetName(char *filename, SHORT phonebook_id, SHORT fileIndex); SHORT FS_file_OpenForRec(SHORT phonebook_id, SHORT phys_index);