FreeCalypso > hg > fc-magnetite
view src/ui3/bmi/mmiBlkResources.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | 6a4d9f47793e |
children |
line wrap: on
line source
#ifndef _MMI_BlkResources_H_ #define _MMI_BlkResources_H_ #define ALLOC_MEMORY mfwAlloc #define FREE_MEMORY mfwFree /******************************************************************************* CONDAT (UK) ******************************************************************************** This software product is the property of Condat (UK) Ltd and may not be disclosed to any third party without the express permission of the owner. ******************************************************************************** $Project name: Basic MMI $Project code: BMI (6349) $Module: PhoneBook $File: MmiBlkResources.h $Revision: 1.0 $Author: Condat(UK) $Date: 25/10/00 ******************************************************************************** Description: The block resource manager handles a list of blocks of information, passing back pointers to the block of data on request. It provides a mechanism for mapping identifiers to strings, bitmaps, melodies or any other block of information. ******************************************************************************** $History: MmiBlkResources.h 25/10/00 Original Condat(UK) BMI version. $End *******************************************************************************/ /* Define the prototypes for the basic routines */ typedef void *tBlkHandle; typedef long int tBlkId; /* The initialisation routine must be called as part of the startup phase of the system, it will allocate working space for the block handler if required, and will initialise any structures required to maintain the correct operation of the functions. This routine must be called prior to invocation of any other block resource function */ tBlkHandle mmibr_Initialise( tBlkHandle BlkBase, int NumEntries ); /* The shutdown function can be called to free any allocations set up by the Initialise routine. In a running system this is unlikely to be called unless a catastrophic error has occurred and the system needs to be restarted. */ void mmibr_ShutDown( tBlkHandle *BlkRsrc ); /* We will adopt a mechanism where each block of data being provided will need to be returned to the block resource manager when it is no longer being used, this will provide an orthogonal approach when dealing with data coming from either ROM or dynamically allocated memory */ tBlkHandle mmibr_Fetch( tBlkHandle BlkRsrc, tBlkId Id ); /* Added to remove warning Aug - 11 */ EXTERN U8 *mfwAlloc (U32 size); /* End - Remove warning */ /******************************************************************************* End of File *******************************************************************************/ #endif