FreeCalypso > hg > fc-magnetite
view src/ui3/bmi/mmiMP3Test.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 6a4d9f47793e |
| children |
line wrap: on
line source
#ifndef _MMIMP3TEST_H_ #define _MMIMP3TEST_H_ 1 /******************************************************************************* CONDAT (UK) ******************************************************************************** This software product is the property of Condat (UK) Ltd and may not be disclosed to any third party without the express permission of the owner. ******************************************************************************** $Project name: Basic MMI $Project code: BMI (6349) $Module: MP3Test $File: MmiMP3Test.h $Revision: 1.0 $Author: Condat(UK) $Date: 18/05/04 ******************************************************************************** Description: MMI Application to test the different Audio file formats. ******************************************************************************** $History: MmiMP3Test.h 18/05/04 Texas Instruments Sep 11, 2006 DR: OMAPS00094182 xrashmic Description: midi and mp3 files is not being populated on accessing corresponding menu, but only during bootup Solution: Populate files on accessing the "browse files" list Jun 06, 2006 REF: ERT OMAPS00070659 x0039928 Bug:MP3 RWD and FWD function - MOT Fix: Forward and Rewind functionalities are handled. Nov 14, 2005 REF: OMAPS00044445 xdeepadh Description: Implementation of Test Menu for AAC Solution: The existing MP3 test Application has been enhanced to support the AAC file testing. The interfaces have been made generic to support both MP3 and AAC files. Sep 27,2005 REF: SPR 34402 xdeepadh Bug:Mono option is always highlighted even when Stereo is selected Fix:The channel setting will be saved in the FFS, which will be retrieved later and the selected channel will be higlighted. Jul 18, 2005 REF: SPR 31695 xdeepadh Bug:Problems with MP3 test application Fix:The window handling of MP3 Test Application has been done properly. $End *******************************************************************************/ EXTERN int mmi_audio_player_set_channel_mono (MfwMnu* m, MfwMnuItem* i); EXTERN int mmi_audio_player_set_channel_stereo (MfwMnu* m, MfwMnuItem* i); //Jul 18, 2005 REF: SPR 31695 xdeepadh EXTERN int mmi_audio_player_files_browse (MfwMnu* m, MfwMnuItem* i); GLOBAL int mmi_audio_player_play (MfwMnu* m, MfwMnuItem* i); //Sep 27,2005 REF: SPR 34402 xdeepadh void mmi_audio_player_set_cur_selected_channels(void); //Sep 11, 2006 DR: OMAPS00094182 xrashmic GLOBAL int mmi_audio_player_Application (MfwMnu* m, MfwMnuItem* i); #if (BOARD == 71) // Jun 06, 2006 REF: ERT OMAPS00070659 x0039928 int M_exePause (MfwMnu* m, MfwMnuItem* i); int M_exeForward (MfwMnu* m, MfwMnuItem* i); int M_exeRewind (MfwMnu* m, MfwMnuItem* i); #endif /******************************************************************************* Include files *******************************************************************************/ extern USHORT record_position; /******************************************************************************* Interface constants *******************************************************************************/ /******************************************************************************* Public methods *******************************************************************************/ /* pretty standard initialise, execute and exit methods */ /******************************************************************************* End of File *******************************************************************************/ #endif