FreeCalypso > hg > fc-magnetite

view src/ui3/mfw/mfw_BtipsOppc.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents e8ddbb0837ed
children
line wrap: on
line source

#ifndef DEF_MFW_BTIPS_OPPC_H
#define DEF_MFW_BTIPS_OPPC_H
/* =========================================================
*             Texas Instruments OMAP(TM) Platform Software
*  (c) Copyright Texas Instruments, Incorporated.  All Rights Reserved.
*
*  Use of this software is controlled by the terms and conditions found
*  in the license agreement under which this software has been supplied.
* ========================================================== */
/*
 $Project name: Basic Bluetooth MMI
 $Project code:
 $Module:   Bluetooth BMG MFW
 $File:       Mfw_BtipsA2dp.h
 $Revision:   1.0
 $Author:   Texas Instruments
 $Date:       26/06/07

********************************************************************************

 Description:

    This module provides the BTIPS A2DP APPlication functionality.

********************************************************************************
 $History: Mfw_BtipsA2dp.h

  26/06/07 Sasken original version

 $End

*******************************************************************************/

/* Maximum files to be displayed in the MMI */
#define OPPC_MAX_FILES 10
//Number of files in content directory.


/*Function Declarations*/
int mfw_btips_oppcPopulateFiles(char **file_names, int max_files_count,
									char* dir_name_p);

void mfw_btips_oppcUnpopulateFiles(char **file_names);
 char *mfw_btips_oppcGetExtension(char *src);
 int mfw_btips_oppcGetNumFiles(void);
 char* mfw_btips_oppcGetFileName(UBYTE index);
 BOOL mfw_btips_oppcGetConnectedDevice (BD_ADDR *bdAddr, U8 *name);
 void mfw_btips_oppc_Disconnect(void);


#endif