FreeCalypso > hg > fc-magnetite

view src/ui3/mfw/mfw_bt_private.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents e8ddbb0837ed
children
line wrap: on
line source

/*******************************************************************************\
*                                                                           	*
*  TEXAS INSTRUMENTS ISRAEL PROPRIETARY AND CONFIDENTIAL INFORMATION			*
*																				*
*  LEGAL NOTE: THE TRANSFER OF THE TECHNICAL INFORMATION IS BEING MADE			*
*	UNDER AN EXPORT LICENSE ISSUED BY THE ISRAELI GOVERNMENT AND THAT THE		*
*	APPLICABLE EXPORT LICENSE DOES NOT ALLOW THE TECHNICAL INFORMATION TO		*
*	BE USED FOR THE MODIFICATION OF THE BT ENCRYPTION OR THE DEVELOPMENT		*
*	OF ANY NEW ENCRYPTION. THE INFORMATION CAN BE USED FOR THE INTERNAL			*
*	DESIGN AND MANUFACTURE OF TI PRODUCTS THAT WILL CONTAIN THE BT IC.			*
*																				*
\*******************************************************************************/
/*******************************************************************************\
*
*   FILE NAME:      mfw_bt_Private.h
*
*   DESCRIPTION:	This file defines the structures needed for BMI BT interface
*                   that are not exposed to BT
*
*   AUTHOR:         Anandhi Ramesh
*
*	Rev 0.1
*
\*******************************************************************************/
#ifndef __MFW_BT_PRIVATE
#define __MFW_BT_PRIVATE
#include "mfw_fm.h"
#include "mfw_bt_api.h"

#define BMI_BT_NOTCONNECTED 0
#define BMI_BT_CONNECTED 1

/*---------------------------------------------------------------------------*/
/*
 * BMI_BT_CMD_SRCTYPE
* Contains the types of commands that can occur. 
 */
/*---------------------------------------------------------------------------*/
typedef enum
{
  BMI_BT_COMMAND_NONE = 0,
  BMI_BT_HANDSET_COMMAND,
  BMI_BT_HEADSET_COMMAND
}BMI_BT_CMD_SRCTYPE;

/*---------------------------------------------------------------------------*/
/*
 * BMI_BT_STRUCTTYPE
 * Global structure that contains the following information
 *    Connection status
 *    State of audio - play/pause/stop etc
 *    Source of the command - could be from headset or handset
 *    callback function for BT
 */
/*---------------------------------------------------------------------------*/
typedef struct
{
    BOOL bConnected;
    T_FM_AUD_STATE tAudioState;
    BMI_BT_CMD_SRCTYPE tCmdSrc;
    void (*BmiEventCallback)(BmiAvEvent);
}BMI_BT_STRUCTTYPE;

#endif // __MFW_BT_PRIVATE